Menu.inc array_merge error

Confirmed error on PHP5 here. Patch does indeed fix problem, which not only creates the warning, but prevents rest of page from showing since output occured before the headers were sent.

I think this error was caused by a callback argument in comment.module that was a string. this has been fixed a few days ago. So I think we won't need this patch. Can somebody confirm this?

Ok, I've been convinced that this is nto the same error. In fact, there is no callback arguement set and that is why it errors out. Please commit.

an alternative patch that goes to the root of the problem (i think) and prevents that empty array wrongly to be set at the first place. there is no 'callback arguments' key in the 'comment/reply' menu item, so it shoudn't be set (to NULL) neither (to not fool later array_key_exists() checks).

please consider this instead.

to be completely sure, there probably should be similar isset() checks around both of

$_menu['items'][$mid]['access'] = $item['access'];
$_menu['items'][$mid]['callback'] = $item['callback'];

as both keys aren't required in menu items (according to drupaldocs.org).

ax's brief patch looks good to me. a few days ago, i tried to track this down for a while but failed. nice work thox and ax.

Tested and confirmed, patch works on PHP5, great find ax!

Correct, ax' patch is the better one, eliminating the root cause.

Committed to HEAD. Thanks.