fix the hook_requirements for checking the demo scripts security hole
scor - September 25, 2008 - 10:31
| Project: | getID3() |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
the hook_requirements does not work. patch attached fixes it. also upgrades the severity to the ERROR level to display a message on the administer page.
Side note: there is a duplicate message in the .module file in getid3_admin_settings_form() which could call hook_requirements() and display the message from there instead.
| Attachment | Size |
|---|---|
| getid3.demos_.patch | 1 KB |
#1
setting status accordingly.
Also, a note concerning the demo scripts could be added in the README.txt and on the project page.
#2
that didn't have the right path in the message. i copied the code from the module that we use on the settings page. give this a try.
#3
yeah that looks even better! will let someone else set to RTBC!
#4
thanks went ahead and committed this to HEAD.
#5
Automatically closed -- issue fixed for two weeks with no activity.