Download & Extend

fix the hook_requirements for checking the demo scripts security hole

Project:getID3()
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

the hook_requirements does not work. patch attached fixes it. also upgrades the severity to the ERROR level to display a message on the administer page.

Side note: there is a duplicate message in the .module file in getid3_admin_settings_form() which could call hook_requirements() and display the message from there instead.

AttachmentSize
getid3.demos_.patch1 KB

Comments

#1

Status:active» needs review

setting status accordingly.
Also, a note concerning the demo scripts could be added in the README.txt and on the project page.

#2

that didn't have the right path in the message. i copied the code from the module that we use on the settings page. give this a try.

AttachmentSize
getid3_313345.patch 1.35 KB

#3

yeah that looks even better! will let someone else set to RTBC!

#4

Status:needs review» fixed

thanks went ahead and committed this to HEAD.

#5

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here