Imagine the following situation:

A user adds a field, or a filter, or whatever, to the view. But she doesn't click the "Update" button in the following form.

Usually, skipping "Update" isn't harmful: the field handler knows to initialize the options to their defaults when it runs.

However, in one case skipping "Update" is harmful: when the "Relationship" dropdown shows anything but the "none" relationship. In this case, neglecting to click "Update" doesn't configure the field to use the relationship the form seems to say that it uses.

The screenshot demonstrates this scenario:

The user has just added the "Flags: Flag link". Views shows "flag" in the relationship dropdown. However, unless the user clicks "Update", this field isn't really connected to that "flag" relationship.

The patch solves the problem by saving the 'relationship' option immediately when the form is shown (but only when needed).

CommentFileSizeAuthor
save_relat.diff972 bytesmooffie
save_relat.png58.19 KBmooffie

Comments

mooffie’s picture

BTW, this situation I described is something users of a module I co-maintain really get into.

merlinofchaos’s picture

Status: Needs review » Fixed

Makes sense. I gather this only happens when 'none' isn't a valid default relationship for that field.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.