Related to the recent issue to add a new vocabulary for handbook page statuses (#304826: Define documentation vocabulary), it would be much more useful if the status could be displayed in a way that highlights it to the readers rather than tucked off as yet another link in the corner. Ideally a message will be displayed at the top of the page that explains what the status means, e.g.:
"This page is marked as incomplete. That means that not all of the required information is included yet. If you would like to help complete this page, you do so by ...blah blah blah." In addition to the text message we could also do visual changes like color or what not but I don't view that as the important target here.
There are two approaches to dealing with this on d.o (that I've thought of):
1. Do it at the theme layer and hardcode it in.
2. Use the Term message module which was actually built for this very purpose.
I don't feel like this is something that has to happen "right away" but sooner rather than later would be nice. :-) My feeling is that using a module is a good idea, but I know that it a) adds yet another module to keep track of and maintain and b) may take a while to get through the review process for inclusion. I don't honestly care how it gets done so I'd like to know which option (or any other option) is preferred so I can rally my energy in the right direction to get it implemented.
Comments
Comment #1
dwwTerm message only has a beta release for 5.x, and no issue about a 6.x upgrade. :( So long as those two facts remain true, I think it's going to be impossible to convince the d.o maintainers to install it for this purpose.
On a whim, I just checked out the term_message directory and found some other unsettling issues:
- All the messages for all terms are stored in a giant variable, which would have to be loaded and unserialized on every d.o page load. :(
- Various code style problems.
- There are a handful of code blocks that are just commented out.
- There appear to be some bugs in how db_query() is used in a few places.
...
In general, I'd rather we used high quality modules to accomplish something we need instead of doing a d.o-specific hack in the theme or in drupalorg.module. Makes it more likely that other people will contribute to upgrading, maintaining and improving the functionality. However, I'd say term_message needs a fair bit of work (and possibly a backend redesign to not rely on variables for everything) to be suitable for use on d.o.
Note: This could be very useful for release nodes with their "Release type" taxonomy terms, and potentially other vocabs we want to add (e.g. for project nodes to mark them "unsupported", "abandoned", "needs maintainer", etc) which is another reason I'd rather see a more general-purpose solution than a bluebeach hack.
So, if you feel like rallying your energy into making term_message rock solid and upgrading it to D6, I'd support installing it for this purpose...
Cheers,
-Derek
Comment #2
add1sun commentedYeah, I hadn't poked at the code much but I did expect that it will require a lot of work to make it ready for d.o use and that, since it isn't very actively maintained, I would probably need to at least be a co-maintainer on it. I'm willing to take that on if that is the desired road, but I didn't want to head out that way if folks didn't think it was a good long-term idea. So, great feedback. :-)
Comment #3
mlncn commentedI wrote Term Message as a proof of concept as a way to keep nodes from being deleted off Drupal.org (but just deprecated and marked as such). Since the only purpose of writing it was to be on Drupal.org (for me at this time, though I think it will be generally useful), I haven't put any work in since.
My misgivings about putting everything in the variables table had already been confirmed by Moshe. In general I'm willing to make all improvements and modifications to make it good for D6 and d.o. Willing and by some reports able to learn. (Disclosure: Using CVS for is still a friction for me. Part of my general weakness as a module maintainer.)
add1sun, do you want me to add you as a co-maintainer now?
benjamin, Agaric Design Collective
Comment #4
add1sun commentedWhoa, this totally scrolled down on my issues page. :-) Sorry about that. Benjamin, sure that would be great. I can totally spend time coaching you on CVS or just take over the major CVS duties for the project, whichever you prefer.
I'm going to postpone this issue while we work on term_message and get it all spiffed up to ask Drupal out to the dance. If anyone else is interested in helping on this one, we'll see you in the Term Message issue queue.
Comment #5
silverwing commentedQueue Cleanup -
The http://drupal.org/project/term_message doesn't have a D6 release - is this still something being worked on or considered? Possibly tag with redesign?
Comment #6
mlncn commentedI can do that. Missed Addi's message above, but definitely willing to work on D6 and necessary features for d.o.
Comment #7
silverwing commentedMoving to Documentation to see if this is something desired. (Note: module in question doesn't have any D6-D7 releases.)
Comment #8
jhodgdonI personally don't think this is necessary. The status is highlighted much more now than it was when this issue was filed -- at least for people who can see colors, it is now in a colored box (though still, or rather again, at the top of the right sidebar). For instance, see the page status on these sample pages:
http://drupal.org/node/1021576 (no known problems)
http://drupal.org/node/202483 (insecure code)
http://drupal.org/node/28245 (needs technical review)
etc. You can find pages by status on http://drupal.org/documentation/manage
So... Even if we do feel we need an explanation added to the page status display, why would we need this Term Description module (which still has no 6.x, much less 7.x release)? I think a better implementation would be to put the descriptions into the taxonomy terms themselves (in core, every term has a "description" field on it), and use the theme layer, or the drupalorg module (probably drupalorg -- I think that is where the taxonomy information is moved to the right sidebar anyway and separated out by taxonomy type) to display the term descriptions for the page status. That is about 2 lines of code, and would be portable to Drupal 7 (a major concern now).
Anyway, I'll leave this issue open for discussion for now. Any thoughts?
Comment #9
dwwAgreed with #8 for the technical approach. If we need a description, let's just use core instead of a separate contrib.
That said, not sure we actually need more description for this. ;) I'll let others debate that.
Cheers,
-Derek
Comment #10
leehunter commentedComment #11
quietone commentedThere has been no discussion here for 11 years, therefore closing.