Posted by sanduhrs on September 26, 2008 at 1:41pm
Jump to:
| Project: | OpenID Provider |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (works as designed) |
Issue Summary
i think it would be usefull, to have a whole section for menu items on the administration page, as there will come multiple add-on modules to implement the different extensions [1]. Adding a new menu item per extension under admin/settings/* seems confusing to me.
Patch attached, please review.
[1] http://openid.net/specs/openid-attribute-exchange-1_0.html
http://openid.net/specs/openid-simple-registration-extension-1_1-01.html
http://openid.net/specs/openid-service-key-discovery-1_0-01.html
http://openid.net/specs/openid-dtp-messages-1_0-03.html
http://openid.net/specs/openid-provider-authentication-policy-extension-...
| Attachment | Size |
|---|---|
| openid_provider_menu_0.patch | 1.05 KB |
Comments
#1
Hum, not sure this is required, especially since some of those functionalities are (best) implemented by other modules.
Also, admin/openid is probably already in use.
#2
It's actually a nice improvement, it shows up as a seperate 'task' in the menu and admin/openid is not already in use, so that's fine.
Note that this patch conflicts with #396468: Don't use underscores in URLs.
#3
I've thought about this - and I'm gonna "by design" it for now... I think even if we ever get the openid* modules consolidated in a way that this makes sense - I don't think a top-level admin section makes sense. I'd vote (at that time) for either keeping it under settings or moving it to admin/user ... but not admin/openid.
For now, this is a single config page (with only a few settings)... it belongs at admin/settings.