notice: Use of undefined constant GENERIC_FLV - assumed 'GENERIC_FLV' in /home/vm/public_html/d6dev/sites/all/modules/swftools/genericplayers.module on line 19.

Getting the above error after uploading and installing swftools on drupal 6.x-dev (downloaded today) can't seem to shake the error.

Comments

vm’s picture

vm commented
Title: Use of undefined constant » notice: use of undefined constant
vm’s picture

vm commented
Status: Active » Fixed

uploading genericplayers.module from head to my installation seems to have fixed the problem. Notice is no longer appearing.

vm’s picture

vm commented
Status: Fixed » Active

correction. The issue is still alive. I had suppressed errrors to be written to the log and not to the screen.

regardless of which module player I enabled I receive the notice:

# notice: Use of undefined constant ONEPIXELOUT - assumed 'ONEPIXELOUT' in /home/vm/public_html/d6dev/sites/all/modules/swftools/onepixelout/onepixelout.module on line 14.
# notice: Use of undefined constant GENERIC_FLV - assumed 'GENERIC_FLV' in /home/vm/public_html/d6dev/sites/all/modules/swftools/genericplayers.module on line 19.
# notice: Use of undefined constant GENERIC_MP3 - assumed 'GENERIC_MP3' in /home/vm/public_html/d6dev/sites/all/modules/swftools/genericplayers.module on line 20.
# notice: Use of undefined constant WIJERING4_MEDIAPLAYER - assumed 'WIJERING4_MEDIAPLAYER' in /home/vm/public_html/d6dev/sites/all/modules/swftools/wijering4/wijering4.module on line 13.
# notice: Use of undefined constant WIJERING4_IMAGEROTATOR - assumed 'WIJERING4_IMAGEROTATOR' in /home/vm/public_html/d6dev/sites/all/modules/swftools/wijering4/wijering4.module on line 14.
# notice: Use of undefined constant WIJERING4_DOWNLOAD - assumed 'WIJERING4_DOWNLOAD' in /home/vm/public_html/d6dev/sites/all/modules/swftools/wijering4/wijering4.module on line 15
vm’s picture

vm commented

I've suppressed the notices: using php.ini changing error_reporting to E_ALL ^ E_NOTICE

Stuart Greenfield’s picture

Stuart Greenfield commented

You're right - the define() functions were all missing their quotes, going right back to Drupal 5!

Fixed in all branches, but I'll not make new releases until I have a few more bug fixes included to make it worth while.

There are some other errors cropping up too when you try to run with E_ALL reporting, so I'll see if I can iron some of those out too.

Stuart Greenfield’s picture

Stuart Greenfield commented
Status: Active » Needs review

Setting as "patched" as this (just the constants issue) is fixed in branches DRUPAL-5, DRUPAL-6--1 and HEAD, pending inclusion in next release.

Stuart Greenfield’s picture

Stuart Greenfield commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.