Closed (fixed)
Project:
Coder
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Sep 2008 at 20:21 UTC
Updated:
13 Oct 2008 at 13:53 UTC
Jump to comment: Most recent file
There's a t() call on a menu item title in the invite module, line 147, which coder isn't catching. Logging this for closer investigation.
Stella
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | coder_drush_314313.patch | 823 bytes | stella |
Comments
Comment #1
stella commentedThis is actually only not reported on when running coder using drush. If you run it through the UI it works perfectly.
Comment #2
stella commentedIf you run coder reviews using the drush command line method and are providing it with the 'no-empty' option, then if there is only one error reported in the module, it won't be displayed. For example, if you run it on the invite module like this:
Then no results are returned. If you run it without the "no-empty" option, you get one result:
It's to do with the check on the number of results returned on line 117 of coder.drush.inc:
For cases where no problems were found, there is still one entry in the $results array for the "No problems found" text. However if 1 problem was found, then there's still one entry in the $results array and the above line prevents it from being displayed.
The attached patch should fix this.
Cheers,
Stella
Comment #3
douggreen commented@stella, if this fixes it, please commit it. Thanks!
Comment #4
stella commentedCommitted to the DRUPAL-6--2 branch.
Comment #5
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.