Posted by ridefree on September 28, 2008 at 1:33am
7 followers
| Project: | Taxonomy Manager |
| Version: | 6.x-2.x-dev |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
GREAT WORK ! :)
one thing that would make it even nicer is to integrate with taxonomy image and allow users to add images when changing the description of a particular term.
As is now I use taxman... but then go to the tax images area to deal with images ... doable... just a pain .. . :)
Comments
#1
agreed
#2
See #846598: inside filefield_js() use drupal_json instead of drupal_to_js. Headers are of the wrong content type. and https://github.com/malsup/form/commit/b3e48921a64afe8d3b2ae11b10aa24f9ab... for some background behind adding
print drupal_to_js().#3
Added missing
Drupal.attachBehaviors().#4
subscribing
#5
subscribing
#6
This patched failed and had to apply manually. At first it seemed that I was unable to upload an image with no error. Tried in both Mozilla and Chrome.
As it turns out Taxonomy_Image has trouble with spaces in the filename.
Thanks.
#7
First, thanks for contributing the patch. (And thanks also to the maintainers of the Taxonomy Manager module. It's just what I was looking for.) Patch in #3 applies successfully with minor offsets to latest dev release. However, it's not quite working 100%, there are a few issues.
- Coding style: control structures should conform to Drupal coding standards to improve readability. For example...
<?phpif( module_exists('taxonomy_image') ) {
foreach( array('taxonomy_image_current_image_delete', 'taxonomy_image_external') as $key ) {
if( isset($param[$key]) ) $term[$key] = $param[$key];
}
}
?>
should be...
<?phpif (module_exists('taxonomy_image')) {
foreach (array('taxonomy_image_current_image_delete', 'taxonomy_image_external') as $key) {
if (isset($param[$key])) $term[$key] = $param[$key];
}
}
?>
- When adding a new term using the taxonomy manager, if I enter a term description and attach an image at the same time, the description field is not saved. If I do these operations separately, the fields are saved correctly.
- On the edit term overlay, the term image fieldsets have acquired "move" handles like the term title, for moving the overlay around. It's sort of confusing to have these extra handles in the middle of the form. EDIT - This is when using the double tree layout.
--
Taxonomy Image
#8
Not trying to contradict schiavone... I should have mentioned #3 applies successfully using -p1.