Valid XHTML output of irc chat iframe
Chris Charlton - September 28, 2008 - 08:58
| Project: | Mibbit IRC |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
I seems the output of this module for the iframe generated is not valid XHTML since all attributes are not properly quoted.
Example: 'width=500 height=280', should be 'width="500" height="280"'.
Patch attached adding:
- Valid XHTML output of IRC window.
- Fall through text for no-frames and no-script (Javascript being disabled) support.
- DIV added around chat window instead of a Paragraph tag
- ID and Class attributes added to module output for easier styling and interaction with Javascript.
| Attachment | Size |
|---|---|
| mibbit_irc.module.valid_xhtml_output.patch | 1.18 KB |
#1
Thanks for the patch Chris!
Committed to v6 Dev.
#2
Changing to 'fixed'.
#3
Automatically closed -- issue fixed for two weeks with no activity.