I seems the output of this module for the iframe generated is not valid XHTML since all attributes are not properly quoted.

Example: 'width=500 height=280', should be 'width="500" height="280"'.

Patch attached adding:

  • Valid XHTML output of IRC window.
  • Fall through text for no-frames and no-script (Javascript being disabled) support.
  • DIV added around chat window instead of a Paragraph tag
  • ID and Class attributes added to module output for easier styling and interaction with Javascript.
CommentFileSizeAuthor
mibbit_irc.module.valid_xhtml_output.patch1.18 KBChris Charlton

Comments

kmillecam’s picture

kmillecam commented

Thanks for the patch Chris!

Committed to v6 Dev.

senpai’s picture

senpai commented
Status: Needs review » Fixed

Changing to 'fixed'.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.