Closed (fixed)
Project:
Drupal core
Version:
x.y.z
Component:
statistics.module
Priority:
Critical
Category:
Feature request
Assigned:
Reporter:
Created:
17 Sep 2005 at 06:24 UTC
Updated:
18 Sep 2005 at 17:08 UTC
Jump to comment: Most recent file
Comments
Comment #1
dries commentedStoring the session ID is one thing, using it another. How would this affect the existing statistics pages? Would you update them to group/sort by session ID rather than by IP?
Comment #2
jeremy commentedWhy not? Do you see any negative impacts from that, or are you just pointing out that it's missing from the patch?
If the same IP shows up with multiple session ID's, either the same person is using multiple browsers, or it's multiple users behind a NAT device, or...
However, it seems the various "track by IP" type operations no longer exist. I only see "track page visits" tabs on the user page. Why was the ability to track users by IP removed? (it evidently happened a while ago, I'm used to 4.5, and see they're gone as of 4.6...)
Comment #3
chx commentedLet contrib modules use the data. But they can only use what's stored.
Comment #4
kbahey commentedAnything that would restore or improve the functionality that we partially had in 4.5 is welcome.
In 4.5, I was able to "track host" and see if it is a crawler or a human. It was very helpful.
Putting the session in the table is a good idea to track anonymous users.
The only comment here is that it would apply to humans for sure (since they are using browsers, and accept cookies).
But what about crawlers? Do they accept cookies and send them in their next page access? I would be surprised if they did.
Regardless, there is definite value in adding this, only that it will not give the whole picture.
+1 from me.
Comment #5
chx commentedThis is a usability issue. Usability but not in the sense of admin interface but navigational paths. Path analysis is a must if I want to see whether my users are able to find what they seek or not. At this moment this is just not possible.
However, a path analysis module would not be simple therefore I doubt it should be in core.
Comment #6
kbahey commentedI fully agree.
Path analysis is much needed, specially comparing 4.5 to 4.6.
Even if it is not in core, and only a contrib, it will be helpful. Just like I find statistics trends to be very helpful, though it is not in core.
Still +1
Comment #7
jeremy commentedWhy was "track hostname" etc moved when going from 4.5 to 4.6? I assume there was a reason - was it not working? I still use 4.5, and it has worked well for me, aside from the annoyance of finding the person to track in the first place.
Comment #8
dries commentedWill commit. Please provide ugrade path. Thanks.
Comment #9
webchickThis should do it...
Comment #10
webchickI'm sorry! I didn't know that postgres needs its own special way of adding NOT NULL and default when altering a field. This patch should be correct. It also includes the changes in the original patch.
Comment #11
webchickHow about one that's not 0 bytes... (?!?)
Comment #12
m3avrck commentedShouldn't sid be %d and not '%s' ?
Comment #13
chx commentedsid a number?? neh, no it's a md5 'ed something, 32 chars long.
Comment #14
chx commentedComment #15
dries commentedCommitted to HEAD. Thanks.
Comment #16
(not verified) commented