Great work!
Just wanted to mention that color_validate() needs an update on references and logic.
If I had the time to write up the patch, I would, but for now I'll try to list my findings and if you haven't had time to fix it by the time I have, I'll get on it. But please correct me if I'm wrong since this post will be my future reference.
color_validate in color.misc.inc is still looking for:
$info['engine'] (is now reference methods)
$info['schemes'] (is now premade schemes)
$info['image'] (is now images, also found references to img in response messages)
$info['css'] (is now stylesheets)
$info['image']['gradient']
(is now fill and type of fill is passed as first parameter in array - currently supporting 'solid' and 'y-gradient')
Validation of fill needs total make-over.
Also all corresponding drupal_set_message responses need an update.
The following line confuses me:
$theme = $info['theme'];
Is this supposed to be set in color.inc or is this added somewhere by the module? Because the current logic heavily depends on it.
Comments
Comment #1
tonyn commentedAn updated version will be committed after we move color.inc to hook_color(). Thank you for your reminder -- we do have to change those names too. I'll cite this issue when I commit it!
Tony
Comment #2
tonyn commentedComment #3
tonyn commentedPutting this on won't fix.
We may start using a versioning system for the color syntax.