Closed (fixed)
Project:
Comment Notify
Version:
5.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Sep 2008 at 00:09 UTC
Updated:
25 Aug 2010 at 09:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
gregglesThanks for the patch. I think this would be better implemented by supporting the token module #273112: Provide realname support in the existing token system
Then people could just use something like:
[site-url]/comment/reply/[nid]/[cid]
To get the same thing. Right?
Comment #2
gddIf token support was implemented, then yes that would absolutely be the way to go about it.
Comment #3
zilla commentedvery nice. is this part of the current dev?
Comment #4
greggles@zilla - when I commit things I update them to fixed. If it were part of dev you could see it in http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/comment_not...
So, no, it's not.
Comment #5
zilla commentedthanks, gotta start tracking the dev in cvs because there are too many threads to follow and tracking the details on the project page makes no sense...
Comment #6
aclight commentedPatch in #0 applies successfully to 5.x-2.x-dev and 6.x-1.x dev. I think this is a good feature request. I guess it needs to be decided first whether or not comment_notify will require token module. I don't know what effect Dries's comment #273112-4: Provide realname support in the existing token system has on this decision.
Comment #7
gregglesHe seems to be ok with token in general these days: http://drupal.org/node/113614#comment-1185431 (note also that paul.lovvik, works for acquia, is the main contributor to that thread these days).
Comment #8
gregglesHow about this more flexible alternative that gets the same goal, but in a more flexible way?
Comment #9
gregglesNow committed - http://drupal.org/cvs?commit=290170
Comment #10
gregglesComment #11
gregglesThis module is no longer actively developed for Drupal 5. If someone wishes to take over as the 5.x maintainer I would consider it, but these days everyone should really upgrade to Drupal 6.x.