Add nid and cid replacements to allow things like a reply link
heyrocker - September 29, 2008 - 00:09
| Project: | Comment Notify |
| Version: | 5.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | patch (to be ported) |
Description
I wanted to be able to add a link to the outgoing email allowing people to reply to a comment with a single click, so i added a variable !comment_reply_url to the array of available variables. Pretty simple patch and thought you might find it useful
| Attachment | Size |
|---|---|
| reply_link.patch | 433 bytes |
#1
Thanks for the patch. I think this would be better implemented by supporting the token module #273112: Use token module for the email body and subject
Then people could just use something like:
[site-url]/comment/reply/[nid]/[cid]
To get the same thing. Right?
#2
If token support was implemented, then yes that would absolutely be the way to go about it.
#3
very nice. is this part of the current dev?
#4
@zilla - when I commit things I update them to fixed. If it were part of dev you could see it in http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/comment_not...
So, no, it's not.
#5
thanks, gotta start tracking the dev in cvs because there are too many threads to follow and tracking the details on the project page makes no sense...
#6
Patch in #0 applies successfully to 5.x-2.x-dev and 6.x-1.x dev. I think this is a good feature request. I guess it needs to be decided first whether or not comment_notify will require token module. I don't know what effect Dries's comment #273112-4: Use token module for the email body and subject has on this decision.
#7
He seems to be ok with token in general these days: http://drupal.org/node/113614#comment-1185431 (note also that paul.lovvik, works for acquia, is the main contributor to that thread these days).
#8
How about this more flexible alternative that gets the same goal, but in a more flexible way?
#9
Now committed - http://drupal.org/cvs?commit=290170
#10