When removing an input format, the filter.module set all nodes that was using the removed format to the default one. This cause an error with current head version :

user error: Unknown column 'format' in 'where clause'
query: UPDATE node SET format = 1 WHERE format = 5 in
/drupal/head/sandbox/database.mysql.inc on line 99

After checking, the new node revision system moves the 'format' column to the 'node_revisions' table, and filter.module still try to change it in the 'node' table.

imho, the query should be UPDATE node_revisions SET format=1 ..., at least from what i understood of the new node revision system :)

A patch is attached to make the table change from node to node_revisions in filter.module.

CommentFileSizeAuthor
filter_remove.patch871 bytessyllance

Comments

syllance’s picture

syllance commented
Priority: Critical » Normal
Status: Active » Needs review

issue is still there after a fresh update to latest head. having double checked, i dont see any other fix than the one in the proposed patch (changing table from node to node_revisions).

moving this to 'normal' bug as input formats are not deleted everyday, and moving to status patch needs code review to include the fix in the patch queue.

dries’s picture

dries commented
Status: Needs review » Needs work

Patch doesn't apply.

syllance’s picture

syllance commented
Status: Needs work » Closed (fixed)

either patch was already applied, or someone has already fixed the issue, as latest filter.module was fixed to use node_revisions table. works fine now, so the patch is not needed. i'm closing the thread.

thanks