Download & Extend

Help text messes with XHTML validation

Project:Mibbit IRC
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The help text has "" and the special characters are not URL/HTML encoded, so this affects a page being valid XHTML since it thinks that is a tag and not plain text.

Comments

#1

Status:active» needs review

Here's my patch for...

1. Fix the text to be [msg] instead, following the rest of the default help text. For those who have settings already saved, please edit the text yourself or reset to defaults in the administration form.

2. Fix XHTML output by changing border attribute of the iframe to frameborder, which is more cross-browser and is valid for XHTML sites.

3. Added name attribute of iframe, forgot this on last XHTML output patch. Name attribute needed for JavaScript interactivity and other DOM related calls.

AttachmentSize
mibbit_irc-314725-1.module.patch 1.79 KB

#2

Status:needs review» fixed

Committed to dev branch.

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here