In the 5.x version of coder, zero'd lines were reported with no linenum:

Include the CVS keyword $Id$ in each file. This should be in the format // $Id$ or // $Id$

In 6.x--1, however, they've become:

+-1: Include the CVS keyword $Id$ in each file. This should be in the format // $Id$ or // $Id$

Looks retarded.

CommentFileSizeAuthor
#3 314828-negative-line-D6.patch804 bytesdave reid
#2 314828-negative-line-D6.patch792 bytesdave reid

Comments

morbus iff’s picture

morbus iff
they/them
commented
Title: Zeroless lines are set as -1 » Zerod lines are set as -1
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 314828-negative-line-D6.patch792 bytes

Attached patch fixes the issue. Tested and seemed to work fine. Didn't mess with any normal line number errors.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 314828-negative-line-D6.patch804 bytes

Oops...that patch is against 6.x-1.x. Revised patch diff'd against 6.x-2.x.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)

Coder for Drupal 6 is now frozen and only security fixes will be applied. Feel free to update this issue and reopen against 7.x-2.x or 8.x-2.x.