Patch for i18n issues

Thanks! I committed to the Drupal 5 version also, which didn't have any conflicts other than hook_menu(), which didn't need to be updated anyway.

quicksketch: FYI, there's one other internationalization issue not covered by these patches:

flag/flag.module:
+901: Invalid localization code: format_plural(intval($count),$singular,$plural) In format_plural(), the singular and plural strings are literal strings and should not be enclosed within t().

The t() variable should not be used on variables, and the potx module will not be able to extract these strings for translation. It's also not what the t() function was intended for. If you need to translate dynamic variables, then the i18nstrings tt() is a good alternative. The above line of code is within the _flag_format_plural() function, which I couldn't find used anywhere, so this may be a non-issue.

Cheers,
Stella

Thanks stella, I'm not sure what that function is used for, let's discuss in a separate issue. Sam, I committed your #2 to both Drupal 5 and 6 branches.

one other internationalization issue [...]
Invalid localization code: format_plural(intval($count),$singular,$plural) In format_plural()
[...]
The t() variable should not be used on variables

That's not a bug. This is user (administrator) input, so we can't hardcode it.

The above line of code is within the _flag_format_plural() function, which I couldn't find used anywhere

(It's used in the D5 version to generate messages such as "no votes", "1 vote", "3 votes" in views. It was left in D6 as a reminder that we don't have this functionality yet. I see that people aren't clamoring for this functionality, and, besides, it's a job better suited for Views itself or for "Views Bonus", so maybe it's time to remove it.)

Created a new issue for the use of t() on $variables at #316149: Use of t() on $variables