Download & Extend

Blog Entries with No Title Are Not Updated

Project:Simple Blogroll
Version:6.x-1.3
Component:Code/Feeds
Category:bug report
Priority:normal
Assigned:filiptc
Status:closed (fixed)

Issue Summary

I'm using SimpleBlogroll on a site that sometimes has blog entries with blank titles (from blogger.com). In the database, the "last_item' entry is blank, and the blogroll doesn't seem to update when new posts are made after it. I worked around this by writing an entry title (if it's blank) to the database in the function _simpleblogroll_modify_db(), and in _simpleblogroll_build_block() I similarly form the link text after the switch statement by rebuilding the title if it's blank.

Is there a better way to do this?

thx

Comments

#1

Assigned to:Anonymous» filiptc

Yeah, you are right, my bad. I didn't consider that situation. There are several approaches to this, the easiest one being to let simpleblogroll compare timestamps (instead of item titles) if titles are empty and do the update if an item with a newer timestamp exists. I'll post the updated code and release a new version today. Thanks for pointing out the bug. Cheers.

#2

Status:active» needs review

Try out the attached patch and post back.

AttachmentSize
simbleblogroll_315118.patch 1.21 KB

#3

thanx for the quick fix. works for me in my tests.

#4

Status:needs review» fixed

Rolling out 1.4! Cheers.

#5

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here