Move file info from {audio} to {files}

drewish - September 30, 2008 - 05:12
Project:Audio
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

Previous versions of Drupal weren't good about sharing the {files} table so the audio module stored it's files in {audio}. With Drupal 6 modules are supposed to play nice in the {files} table and keep their files there. We need to migrate the data from the {audio} table to the {files} table and then drop the columns from {audio}. It'll also mean touching a lot of the code because {audio} has colums named file_* while {files} uses file*. Touching this much code has me wishing that the audio module had unit tests...

#1

drewish - October 1, 2008 - 22:45
Status:active» needs review

marking #315114: Update audio_image to use the new files stuff in D6 as a duplicate of this and merging the changes in.

there's lots of changes that'll probably introduce bugs but i'd love some testing before i commit this and then find out it deletes everyone's files.

AttachmentSize
audio_315152.patch 61.44 KB

#2

drewish - October 1, 2008 - 23:40
Title:Move file info from {audio} to {files}» Move file info from {audio} and {audio_images} into {files}

fixed a problem loading images from id3 tags.

AttachmentSize
audio_315152.patch 63.47 KB

#3

drewish - October 2, 2008 - 00:17
Title:Move file info from {audio} and {audio_images} into {files}» Move file info from {audio} to {files}
Status:needs review» needs work

small fixes around the feeds

AttachmentSize
audio_315152.patch 63.47 KB

#4

drewish - October 2, 2008 - 18:04
Status:needs work» fixed

went ahead and committed this to HEAD.

#5

Anonymous (not verified) - October 16, 2008 - 18:16
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.