Coder Comments Review
stella - September 30, 2008 - 08:53
| Project: | Google Analytics |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed |
Description
Hi,
I found a couple of small commenting standards issue when running coder on the Google Analytics module. The attached patch fixes these. Though the patch was made against the DRUPAL-6--1 branch, it should also apply cleanly to the DRUPAL-6--2 branch too.
Also, as a side note, you should consider updating your simple tests to work with the newer SimpleTest API, for example, your tests should extend DrupalWebTestCase rather than DrupalTestCase. See the SimpleTest module page for links to the updated docs.
Cheers,
Stella
| Attachment | Size |
|---|---|
| google_analytics_comments.patch | 1.27 KB |
#1
Re-rolled the patch with some formatting corrected. Also removed the @file comment block for the test file from my last patch since according to current standards at http://groups.drupal.org/node/7731 no @file comments should be used for test files, though this may change in the future.
#2
Do you know how to update simpletest? Is it only the above name change? If not - are you able to upgrade?
#3
No, I'm afraid I don't really. I'm pretty sure that
get_info()was renamed togetInfo(), but I don't know what the other changes were. The changes came about because the new version doesn't use the external simpletest library. The google analytics code only uses a small number of simpletest functions so you could check the api functions listed at http://drupal.org/node/30023 and see if any have changed. Sorry I can't give you any more info.Cheers,
Stella
#4
We need to find someone who can update the simpletest stuff... :-)
#5
Commenting standards for test files have changed (http://groups.drupal.org/node/7731), so here's a patch that adds in the @file block to the test file that I had in my original patch.
Cheers,
Stella
#6
Trivial patch, RTBC.
#7
#8
Automatically closed -- issue fixed for two weeks with no activity.