search_files does not show correct snippet when a stemmer is installed

now that you have brought this to my attention I agree that it needs to be fixed. if you would create a patch it would be most useful, otherwise it will take me more time to get this change made.

I couldn't get this patch to work as expected. I applied it against 1.6 and the snippet disappeared (which is admittedly better than the trimmed words). I expected it to show the full snippet but without the trimmed stem. I uninstalled, reinstalled and did not get any results from search files at all, but probably not related the patch? Not sure, and since there is a 2.0 dev version I decided to try that.

This problem exists in the 2.0 beta4 version as well. With stemming the words are trimmed to their stems.

Since this issue is pretty old and it looks like the 2.0 version is the way to go now, I am going to update this issue and set it to the new version and make the status active. Hope that's OK.

Ah, OK. That makes more sense now. I was using the English porter stemmer. I wasn't actually using this module on a site but just taking some time to review patches (patch bingo). This one popped up and the functionality seems useful so I thought I'd give it a try.

I'd review it against German but ich spreche kein Deutsch!

Hello,

The problem with a snippet of stemmed words also exists for search attachments. The patch doesn't work there; there's no table for attachments to save the original text. Is it necessary to create a new table for attachments and changing the code in the same way as for files?
A new table and a lot of code, just for a correct search-snippet, or is there another way?

Erik Greve
www.kennisakker.nl

Ok then, for search attachments I've added an extra table:

function search_files_attachments_update_6202() {
  $schema['search_files_attachments'] = array(
    'description' => t('unstemmed text of attachments that we need for snippet'),
    'fields' => array(
      'id' => array('type' => 'int', 'not null' => TRUE, 'disp-width' => '11'),
      'content' => array('type' => 'text', 'size' => 'big', 'not null' => FALSE, 'default' => ''),
    ),
    'primary key' => array('id'),
  );
  $ret = array();
  if (!db_table_exists('search_files_attachments')) {
    db_create_table($ret, 'search_files_attachments', $schema['search_files_attachments']);
  }
  return $ret;
}

Then a few extra lines in this function:

function search_files_attachments_index_file($file) {
  $contents = search_files_attachments_get_file_contents($file->filepath);
  if ($contents) $contents = search_files_convert_to_utf8("{$file->filename} ". $contents);
  search_index($file->fid, 'search_files_att', $contents);
-->  $set_text = "UPDATE {search_files_attachments} SET content = '%s' WHERE id = %d";
-->  db_query($set_text, $contents, $file->fid);
-->  if (!db_affected_rows()) {
-->    $set_text = "INSERT INTO {search_files_attachments} (id, content) VALUES (%d, '%s')";
-->    @db_query($set_text, $file->fid, $contents);
-->  }
  return $contents;
}

And last but not least, added/changed two lines in the hook_search-function:

$text = db_result(db_query("SELECT content FROM {search_files_attachments} WHERE id = %d", $item->sid));
'snippet' => search_excerpt($keywords, $text),

That did the trick!

Erik Greve
(sorry, I can't make patches)