is this in planning?
couldn't find the module in CVS either

Comments

torgospizza’s picture

Yeah, I haven't had a chance to add it to CVS yet. I think a D6 port would be in order, but I will probably hold off until I get the new features into the D5 version.

Of course I could always just branch the two 1.0 versions and keep them both in there. I'll think about what the best way to go is - any suggestions?

frankcarey’s picture

Yes, please upload, then make 2 branches

cjdavis’s picture

Any further status on a D6 version? This module is exactly what I am looking for, but I need it for D6

Thanks!

torgospizza’s picture

Version: » 5.x-1.x-dev

Still no status. Right now I do have a couple test sites I could install it on, but my time is stretched pretty thin with other projects (and since I only have one commerce site, which runs on D5, it's not my highest priority). I'll see what I can do in the next couple weeks, though.

torgospizza’s picture

Status: Active » Postponed
cedarm’s picture

Status: Postponed » Needs review
StatusFileSize
new35.67 KB
new16.94 KB
new40.62 KB

Here it is. I first plowed through coder cleaning up things, then made the D6 modifications. The uc_upsell_20090210-6_orig-d6.patch is a diff from version 1.7.

For sake of easy review, there's also a diff with just the D6 mods, diffed from the cleaned up D5 code, uc_upsell_20090210-6_clean-d6.patch.

In case you wish to apply the cleanup to the D5 codebase, uc_upsell_20090210-6_orig_cleanup.patch.

duntuk’s picture

thank you for the patch, can you also post the full drupal 6 module?

cedarm’s picture

StatusFileSize
new10.09 KB

FYI, the patches only apply cleanly when everything has unix style line endings. So,
dos2unix uc_upsell.module
then
patch -p1 <uc_upsell_20090210-6_orig-d6.patch

Attaching full module as requested. (You really should learn to use patch...)

torgospizza’s picture

Thanks for the patches. I should have a D6 site I'll be able to test this on soon, as well as do any additional development with, since I have some feature additions I'll be making in the near future.

liliplanet’s picture

subscribe, thx!

ragavendra_bn’s picture

Thanks torgosPizza and cedram.............[:)]

torgospizza’s picture

Just FYI if you're going to patch, patch to the 1.7 version. The Dev version is obviously newer and has more features in it. In the next couple weeks I'll put up an official D6 branch. Hang on just a little while longer! (If you need it sooner than that, please let me know.)

duntuk’s picture

thanks torgosPizza for help. Really appreciate your hard work.

ps. i was more referring to starting a D6 version/branch so user don't have to use the issues to get the latest d6 version.

"Attaching full module as requested. (You really should learn to use patch...)"

torgospizza’s picture

Yeah I want to start a D6 branch as soon as I have time to convert the latest version of the module over :) I will take care of that soon, probably this week.

torgospizza’s picture

Hi, there's now a D6 port of the latest build of the module. Grab it at the main project page: http://drupal.org/project/uc_upsell

torgospizza’s picture

Assigned: Unassigned » torgospizza
Status: Needs review » Fixed

Closing this issue, please post any issues with the D6 branch in the Issue Tracker.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.