is this in planning?
couldn't find the module in CVS either
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | uc_upsell-6.x-1.7.tar_.gz | 10.09 KB | cedarm |
| #6 | uc_upsell_20090210-6_orig-d6.patch | 40.62 KB | cedarm |
| #6 | uc_upsell_20090210-6_clean-d6.patch | 16.94 KB | cedarm |
| #6 | uc_upsell_20090210-6_orig_cleanup.patch | 35.67 KB | cedarm |
Comments
Comment #1
torgospizzaYeah, I haven't had a chance to add it to CVS yet. I think a D6 port would be in order, but I will probably hold off until I get the new features into the D5 version.
Of course I could always just branch the two 1.0 versions and keep them both in there. I'll think about what the best way to go is - any suggestions?
Comment #2
frankcarey commentedYes, please upload, then make 2 branches
Comment #3
cjdavis commentedAny further status on a D6 version? This module is exactly what I am looking for, but I need it for D6
Thanks!
Comment #4
torgospizzaStill no status. Right now I do have a couple test sites I could install it on, but my time is stretched pretty thin with other projects (and since I only have one commerce site, which runs on D5, it's not my highest priority). I'll see what I can do in the next couple weeks, though.
Comment #5
torgospizzaComment #6
cedarm commentedHere it is. I first plowed through coder cleaning up things, then made the D6 modifications. The uc_upsell_20090210-6_orig-d6.patch is a diff from version 1.7.
For sake of easy review, there's also a diff with just the D6 mods, diffed from the cleaned up D5 code, uc_upsell_20090210-6_clean-d6.patch.
In case you wish to apply the cleanup to the D5 codebase, uc_upsell_20090210-6_orig_cleanup.patch.
Comment #7
duntuk commentedthank you for the patch, can you also post the full drupal 6 module?
Comment #8
cedarm commentedFYI, the patches only apply cleanly when everything has unix style line endings. So,
dos2unix uc_upsell.modulethen
patch -p1 <uc_upsell_20090210-6_orig-d6.patchAttaching full module as requested. (You really should learn to use patch...)
Comment #9
torgospizzaThanks for the patches. I should have a D6 site I'll be able to test this on soon, as well as do any additional development with, since I have some feature additions I'll be making in the near future.
Comment #10
liliplanet commentedsubscribe, thx!
Comment #11
ragavendra_bn commentedThanks torgosPizza and cedram.............[:)]
Comment #12
torgospizzaJust FYI if you're going to patch, patch to the 1.7 version. The Dev version is obviously newer and has more features in it. In the next couple weeks I'll put up an official D6 branch. Hang on just a little while longer! (If you need it sooner than that, please let me know.)
Comment #13
duntuk commentedthanks torgosPizza for help. Really appreciate your hard work.
ps. i was more referring to starting a D6 version/branch so user don't have to use the issues to get the latest d6 version.
"Attaching full module as requested. (You really should learn to use patch...)"
Comment #14
torgospizzaYeah I want to start a D6 branch as soon as I have time to convert the latest version of the module over :) I will take care of that soon, probably this week.
Comment #15
torgospizzaHi, there's now a D6 port of the latest build of the module. Grab it at the main project page: http://drupal.org/project/uc_upsell
Comment #16
torgospizzaClosing this issue, please post any issues with the D6 branch in the Issue Tracker.