Download & Extend
Simple Paypal Framework » Issues

Add hook_requirements() for curl instead of failing silently when transactions are done ...

Posted by ksenzee on September 30, 2008 at 4:37pm
Project:Simple Paypal Framework
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:ksenzee
Status:needs review

Issue Summary

There probably ought to be a hook_requirements check for curl, or at least a log entry if curl_init fails. This is especially important because the curl calls happen in simple_paypal_ipn_verify, which is hard to debug since it's normally called when you get an IPN from PayPal.

Login or register to post comments

Comments

#1

Posted by kbahey on September 30, 2008 at 4:52pm
Version:5.x-1.1» 5.x-1.x-dev

Certainly a good idea.

hook_requirements() seem the best way to go.

Can you contribute a patch?

#2

Posted by kbahey on September 30, 2008 at 4:53pm
Title:will silently fail if curl isn't enabled» Add hook_requirements() for curl instead of failing silently when transactions are done ...
Status:active» needs work

#3

Posted by ksenzee on September 30, 2008 at 5:17pm
Assigned to:Anonymous» ksenzee

Sure, when I get a minute.

#4

Posted by ksenzee on October 1, 2008 at 5:17pm

I'm attaching a new .install file for the module with simple_paypal_requirements function (just remove the .txt extension). Sorry it's not a patch -- I'm not sure how to cvs diff a new file on a read-only repo.

AttachmentSize
simple_paypal.install.txt 1.05 KB

#5

Posted by kbahey on October 1, 2008 at 10:01pm
Status:needs work» needs review

thank you for the patch.

I included it in the dev version, and it should be present in tomorrow's tarball.

If it gets sufficient testing, I will create a stable version.