Closed (works as designed)
Project:
Journal
Version:
6.x-1.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Sep 2008 at 20:05 UTC
Updated:
2 Jun 2009 at 10:49 UTC
I upgraded to the D6 version from the D5 version and got:
user warning: Duplicate key name 'location' query: ALTER TABLE journal ADD INDEX location (location(32)) in /includes/database.mysql-common.inc on line 434.
It looks like in journal.install that there is journal_update_6100 and journal_update_6101 which were previously named journal_update_5100 and journal_update_5101. I don't think the update functions should have had their names changed if they are the same old updates since this causes them to be rerun.
Comments
Comment #1
sunThe good news first: Those updates did not harm your data or site. You can ignore those update messages about Journal module.
The bad news: Unfortunately, those updates have not been renumbered, they are needed in both versions of the module. We have a critical update system conflict in Drupal core currently. See #136078: New module update numbering scheme for contrib modules for further information.
Marking as postponed until there is a solution in above mentioned issue.
Comment #2
aaron commentedyou'll probably want to skip the update if it's been run in that case. something like
Comment #3
sunWell, you probably want to read the last ~15 follow-ups of the above mentioned issue to understand why the proposed workaround does not work out.
Comment #4
sunThe solution is to add db_primary_key_exists() and db_index_exists() to Drupal core, so modules can properly test whether an update like this has to run. In all other cases, modules are able to run updates conditionally already.
Comment #5
sun