We need someone who is familiar with the new simpletest version and can update the old file. Here is also a link to the simple test api docs http://drupal.org/node/30023.

CommentFileSizeAuthor
#8 ga.patch447 bytesnancydru
#3 googleanalytics_basic.test3.95 KBhass
#1 ga_simpletest_2008111501.patch2.06 KBhass

Comments

hass’s picture

hass commented
Title: Need help: Update test's for new simpletest version » Update test's for new simpletest 2.x version
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new ga_simpletest_2008111501.patch2.06 KB

Could someone test this patch, please? I cannot get simpletest working on my box...

hass’s picture

hass commented

I cannot run any tests with this buggy simpletest module. See #334554: SimpleTest: Prevent endless loop and upper timeout during request.

hass’s picture

hass commented
StatusFileSize
new googleanalytics_basic.test3.95 KB

This test file currently mess up your site. See #335655: SimpleTest: variable_set() mess up installation. Only execute this tests on a test database where you don't care about any settings.

hass’s picture

hass commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Priority: Normal » Critical
Status: Closed (fixed) » Active

public static function getInfo()

If this is not done, Simpletest dies.

hass’s picture

hass commented

Please provide a patch.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Active » Needs review
StatusFileSize
new ga.patch447 bytes

This took me far longer than it would have taken you to type in 14 characters. I have tested it and it works.

hass’s picture

hass commented

At the time of writing the tests my code was correct as I know, why is this change required and what will this change?

hass’s picture

hass commented
Status: Needs review » Fixed

I'm thinking about removing all tests from all my projects until this stuff is stable. Every 4 weeks a small change suxxx.

hass’s picture

hass commented
Title: Update test's for new simpletest 2.x version » Update test's after latest simpletest 2.x changes
nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I don't recall the patch that changed this. I think it has to do with PHP's strict mode. It's not just you, I had to change almost every module's tests. The problem is that even the 6.x branch is following HEAD for 7.x.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Title: Update test's after latest simpletest 2.x changes » Update tests after latest simpletest 2.x changes

http://blog.boombatower.com/simpletest-6.x-2.8-fresh-backport

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.