Searched for this issue before submitting this and didn't find anything.

Log message claims that Feed url is updated upon 301 redirect, but break in switch statment prevents that from happening. Attached patch fixes that. Tested on /. rss feeds which do a redirect.(20:59:43) Amazon: Anyone around?
(20:59:49) Amazon: trying to debug my aggregator
(21:02:34) linuxcolumbus: what is it doing?
(21:04:16) Amazon: http://slashdot.org/index.rss
(21:04:24) Amazon: I added slashdot as my aggregator
(21:04:28) Amazon: as my feed
(21:04:38) Amazon: and I added a category
(21:04:44) Amazon: then I hit cron.php
(21:04:56) Amazon: it doesn't add up
(21:05:06) Amazon: it doesn't get the feeds
(21:06:12) Oadae left the room (quit: Remote closed the connection).
(21:07:33) linuxcolumbus: Did you try going into the aggregator link under administration and using the update feeds option?
(21:08:01) linuxcolumbus: update feeds = update items.
(21:08:26) Amazon: clicked on update items: nothing
(21:08:45) linuxcolumbus: Hum.... I'll try it on my site.
(21:09:56) linuxcolumbus: ditto here, I get nothing.
(21:10:37) Amazon: really
(21:10:57) filhocf left the room.
(21:10:59) Amazon: linuxcolumbus: I am updating the aggregator documenation
(21:11:13) Amazon: http://drupal.org/handbook/modules/aggregator
(21:11:20) Amazon: because there are 18 comments
(21:11:26) Amazon: some over two years old
(21:11:37) Amazon: so I need a working aggregator to sort through the comments
(21:11:39) linuxcolumbus: looks like there is a redirect getting in the way. Try http://rss.slashdot.org/Slashdot/slashdot
(21:13:15) Amazon: ok, that worked thanks
(21:15:10) linuxcolumbus: I just cut and pasted an rss link from /. for a particular category and it did the same thing. must be a bug in aggregator. If you get a chance could you check, if not I can.
(21:21:24) Amazon: I have two feeds
(21:21:34) Amazon: that's good enough to write documentation
(21:22:25) linuxcolumbus: Yep, I looked through the bug list and didn't see anything.

CommentFileSizeAuthor
aggregator_fix_301.patch659 bytesvwX

Comments

gerhard killesreiter’s picture

gerhard killesreiter commented

patch still applies, but I am not aggregator expert...

dries’s picture

dries commented

I don't think the patch will work. IMO, we need to replace $feed['url'] = $result->redirect_url; with a db_query() that updates the URL in the database. Then, things will work next time cron runs...

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Fixed

Tested (the feed URL is updated in the database) and committed to HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)