Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The new row wrapping div
-tag needs an additional class so you can target all rows with one css selector.
Today it looks like the following:
<div class="views-row-n views-row-odd">
...row data...
</div>
To be able to target all rows we have to add a class like this (this also follows the pattern used in views fields):
<div class="views-row views-row-n views-row-odd">
...row data...
</div>
Comment | File | Size | Author |
---|---|---|---|
#5 | views_row_class-315915-5.patch | 563 bytes | BWPanda |
row_class_name-1.patch | 769 bytes | dixon_ | |
Comments
Comment #1
dixon_If you didn't already notice, I attached a patch that fixes the issue.
Comment #2
stephthegeek CreditAttribution: stephthegeek commentedmerlinofchaos, just to respond to your question on IRC earlier, I'm +1 on this so there's a general row class in there.
The class names are long though and I think you could drop the "views-" part of them (since you can always target the standalone "views" class higher up), but I'm guessing you probably don't want to change that now anyway :)
Comment #3
merlinofchaos CreditAttribution: merlinofchaos commentedThe views- is mostly protection against themes that use generic tags. Every time I don't use view- whatever, some theme breaks things and it's all my fault. :P
Comment #4
dixon_I agree that the "views-" part is necessary. In almost all cases modules should user their name as a prefix. There are some general cases that I tend to skip this pattern. But I generally agree.
Comment #5
BWPanda CreditAttribution: BWPanda commentedThe latest .dev doesn't seem to have this yet...
I've attached an updated patch so we can hopefully get this committed.
Comment #6
merlinofchaos CreditAttribution: merlinofchaos commentedCommitted. THanks!