The new row wrapping div-tag needs an additional class so you can target all rows with one css selector.

Today it looks like the following:

<div class="views-row-n views-row-odd">
...row data...
</div>

To be able to target all rows we have to add a class like this (this also follows the pattern used in views fields):

<div class="views-row views-row-n views-row-odd">
...row data...
</div>
CommentFileSizeAuthor
#5 views_row_class-315915-5.patch563 bytesAnonymous (not verified)
row_class_name-1.patch769 bytesdixon_

Comments

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented
Status: Active » Needs review

If you didn't already notice, I attached a patch that fixes the issue.

stephthegeek’s picture

stephthegeek commented

merlinofchaos, just to respond to your question on IRC earlier, I'm +1 on this so there's a general row class in there.

The class names are long though and I think you could drop the "views-" part of them (since you can always target the standalone "views" class higher up), but I'm guessing you probably don't want to change that now anyway :)

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Reviewed & tested by the community

The views- is mostly protection against themes that use generic tags. Every time I don't use view- whatever, some theme breaks things and it's all my fault. :P

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented

I agree that the "views-" part is necessary. In almost all cases modules should user their name as a prefix. There are some general cases that I tend to skip this pattern. But I generally agree.

Anonymous’s picture

Anonymous (not verified) commented
Version: 6.x-2.0-rc4 » 6.x-2.x-dev
StatusFileSize
new views_row_class-315915-5.patch563 bytes

The latest .dev doesn't seem to have this yet...
I've attached an updated patch so we can hopefully get this committed.

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Committed. THanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.