Download & Extend

Filter affects URLs inside HTML links

Project:Pirate
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:sillygwailo
Status:closed (fixed)

Issue Summary

For example a link to http://www.bmannconsulting.com/blog/bmann/talk-like-a-pirate-day becomes a link to http://www.bmannconsultin'.com/blog/bmann/talk-like-a-pirate-day

Comments

#1

Assigned to:Anonymous» sillygwailo

#2

Following this link apparently turns ME into a pirate: http://acko.net/dumpx/ccg4.jpg

#3

Is this module abandoned?

I realize it only gets attention once a year, but it still munges URLs.

#4

The module is not abandoned, I just don't have a good fix for this issue yet (he says almost a year later, oops).

#5

Did this get fixed?

Its another year and would like to know if the links on the site dont break this month.

I guess this uses the input filter so wouldnt be a matter of altering it there to ignore links?

#6

It hasn't been fixed yet. One promising approach is to use what the URLFilter module (now included in core) does, which is to ignore text, such as URLs inside tags.

#7

Version:master» 7.x-1.x-dev

I've committed and pushed a potential fix to this in the dev version for 7.x, which should update shortly. If it works I'll backport to 6.x. In order to test, you'll have to remove the conditional which checks for the date in pirate_filter_process().

#8

Status:active» needs review

#9

Committed a similar potential fix for D6. In fact, it's the same code (using D7's Filter module code in a D6 module...).

#10

Status:needs review» fixed

#11

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here