This patch was originally inside of a really large patch, was suggested to split into smaller patches.

Tests needed: common.inc
http://drupal.org/node/276272

CommentFileSizeAuthor
#5 custom_access_denied_test_3.patch3.9 KBgrndlvl
#3 custom_access_denied_test_2.patch2.46 KBgrndlvl
custom_access_denied_test_1.patch1.82 KBgrndlvl

Comments

grndlvl’s picture

grndlvl commented
Priority: Normal » Critical

Just getting same priority as parent task.

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Needs work

I think we should refactor this one with PageNotFoundTestCase from system.test. After all, those are exactly the same, the only thing that change is the target path.

grndlvl’s picture

grndlvl commented
Status: Needs work » Needs review
StatusFileSize
new custom_access_denied_test_2.patch2.46 KB

Per comment #2 suggestion this patch now applies this test to system.test rather than common.test.

c960657’s picture

c960657 commented

Looks good. I tested the patch, and it works for me.

Two suggestions:

  • Also verify the HTTP response code using assertResponse().
  • Rename the test to "403/404 errors" (or "403/404 errors pages") for consistency with the text on admin/settings:
    Error reporting
    Control how Drupal deals with errors including 403/404 errors as well as PHP error reporting.
grndlvl’s picture

grndlvl commented
StatusFileSize
new custom_access_denied_test_3.patch3.9 KB

made suggested changes from comment #4.

swentel’s picture

swentel commented

What's the difference with http://drupal.org/node/296306 ?

lilou’s picture

lilou commented

@swentel : I think test in #296306: TestingParty08: 403 page needs a test is also include in the last patch of this issue.

grndlvl’s picture

grndlvl commented
Status: Needs review » Fixed

It seems that http://drupal.org/node/296306, contains all that this patch covered.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.