Test for Custom Access Denied

Posted by grndlvl on October 2, 2008 at 11:32am

Issue Summary

This patch was originally inside of a really large patch, was suggested to split into smaller patches.

Tests needed: common.inc
http://drupal.org/node/276272

Attachment	Size	Status	Test result	Operations
custom_access_denied_test_1.patch	1.82 KB	Ignored: Check issue status.	None	None

Comments

#1

Posted by grndlvl on October 2, 2008 at 11:38am

Priority:

normal

» critical

Just getting same priority as parent task.

#2

Posted by Damien Tournoud on October 2, 2008 at 11:55am

Status:

needs review

» needs work

I think we should refactor this one with PageNotFoundTestCase from system.test. After all, those are exactly the same, the only thing that change is the target path.

#3

Posted by grndlvl on October 8, 2008 at 2:19am

Status:

needs work

» needs review

Per comment #2 suggestion this patch now applies this test to system.test rather than common.test.

Attachment	Size	Status	Test result	Operations
custom_access_denied_test_2.patch	2.46 KB	Ignored: Check issue status.	None	None

#4

Posted by c960657 on October 8, 2008 at 7:20pm

Looks good. I tested the patch, and it works for me.

Two suggestions:

Also verify the HTTP response code using assertResponse().
Rename the test to "403/404 errors" (or "403/404 errors pages") for consistency with the text on admin/settings:
Error reporting
Control how Drupal deals with errors including 403/404 errors as well as PHP error reporting.