Patch for Coder Review fixes
stella - October 2, 2008 - 13:18
| Project: | Buddylist2 |
| Version: | 6.x-1.x-dev |
| Component: | Buddylist UI |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Jump to:
Description
Hi,
CivicActions is reviewing and upgrading multiple modules for use on client sites. Part of this work is a code review using the coder module. Only a couple of small problems were found, and I've attached a patch to fix these.
Both of the issues found are the same and neither are actual bugs. However, now in Drupal 6 there is a better way to handle this case. It involves the use of the new db_placeholders() function. See http://drupal.org/node/114774#placeholder_helper and http://api.drupal.org/api/function/db_placeholders for more info.
Cheers,
Stella
| Attachment | Size |
|---|---|
| buddylist2_sql.patch | 1.65 KB |
#1
#2
Hi stella,
first of all many thanks for the patch! Do you have reviewed all competing modules for drupal 6 (friendslist, user relationships, ...)? If so, will there be a public summary somewhere?
At the moment developement of Buddylist2 for Drupal 6 is stopped. With the rise of the very simular friendslist module it would not make much sense to compete against. Hope this was the right decision and everybody is fine with that. But some more opinions for pro and cons of these modules would be still interesting though.
#3
there will be no supported d6 version.