Found this in drupal 4.6.2 and appears to still be the case in cvs.
In a forum topic list where it shows "# new" in the replies column this link has a #new anchor but never has a from= parameter.. so if the topic is very long (more comments than will be displayed one one page when viewing the topic from the beginning) then following the link doesn't show the new comments. I've attached a patch which resolves this for gallery.sf.net.. we don't use different sort orders for comments, so I'm not sure if additional code might be needed to account for sort orders.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | tracker.module_new_patch.txt | 1.16 KB | mindless |
| #3 | forum.module_new_patch.txt | 1.74 KB | mindless |
| #1 | forum.module_cvs_patch.txt | 1.71 KB | mindless |
| forum.module_patch.txt | 1.75 KB | mindless |
Comments
Comment #1
mindless commentedPatch for current cvs.
Comment #2
mindless commentedUpdate status.
Comment #3
mindless commentedUpdated patch again for current cvs.
Comment #4
mindless commentedHere is the same patch for tracker.module. Like the patch above, it assumes normal/unchanging sort order. See 6162 for development of what looks like a more complete solution.
Comment #5
drummNeeds to handle the different orders and such.
Comment #6
vph commentedThe patch of the forum module (in particular the line below) doesn't seem to work for 4.7.2
$page_param = $page_with_new ? ('from='. ($page_with_new * $comments_per_page)) : NULL;Instead, this works for me:
Comment #7
artem_sokolov commentedI can confirm the correction in the #6 response on 4.7.0
Comment #8
ChrisKennedy commentedDuplicate of http://drupal.org/node/6162
Comment #9
ChrisKennedy commenteddupe