Download & Extend
Issues

OpenID icon misplaced under login text

Posted by Aren Cambre on October 3, 2008 at 2:48am
Project:Drupal core
Version:6.x-dev
Component:openid.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:CSS

Issue Summary

On the Chameleon theme delivered with drupal, the OpenID icon appears right under "Log in using OpenID". Example is attached.

I would have selected the Chameleon theme in the dropdown, but it's not present.

AttachmentSizeStatusTest resultOperations
chameleon.png154.71 KBIgnored: Check issue status.NoneNone
Login or register to post comments

Comments

#1

Posted by Rob Loach on October 3, 2008 at 5:28am
Version:6.4» 7.x-dev
Component:other» openid.module

I've seen this happen everywhere.

#2

Posted by Aren Cambre on October 3, 2008 at 2:59pm

Should this possibly minor bug be fixed in 6?

#3

Posted by momendo on March 7, 2009 at 9:53pm

CSS bug confirmed in FF3, IE6/7, Safari3, Opera 9.6.

We need a CSS ninja to come in and fix...

#4

Posted by momendo on March 7, 2009 at 10:13pm
Status:active» needs work

Moved over the padding. A caveat however, IE6/7 shows the standard bullet from ul.leaf. It's annoying somewhat.

AttachmentSizeStatusTest resultOperations
openid-css.patch545 bytesIdlePassed: 10671 passes, 0 fails, 0 exceptionsView details
Picture 5.png8.02 KBIgnored: Check issue status.NoneNone

#5

Posted by momendo on March 8, 2009 at 12:05am

I tested the patch in IE8 beta 1. The stray ul.leaf bullet isn't there, so I'm satisfied that the CSS is correct and IE6/7 just has priority bugs in regards to background images.

#6

Posted by momendo on March 8, 2009 at 1:57pm
Title:OpenID icon misplaced on Chameleon theme» OpenID icon misplaced under login text

Retitling... occurs in all themes.

#7

Posted by momendo on March 8, 2009 at 8:12pm
Status:needs work» needs review

Moving to review to get more eye balls.

#8

Posted by Dries on March 8, 2009 at 9:15pm

Does that fix the problem at http://mollom.com/user/login (for example)?

#9

Posted by momendo on March 8, 2009 at 9:56pm

It appears so. I loaded up Mollom and applied the patch through Firebug. It looks good too.

In IE7, it also shifts left too. I see a 3px shift down but I guess that's specific to Mollom CSS.

AttachmentSizeStatusTest resultOperations
Picture 2.png297.86 KBIgnored: Check issue status.NoneNone
Picture 1.png186.63 KBIgnored: Check issue status.NoneNone

#10

Posted by momendo on March 9, 2009 at 12:36am
AttachmentSizeStatusTest resultOperations
openidcss.patch1014 bytesIdlePassed: 10671 passes, 0 fails, 0 exceptionsView details

#11

Posted by momendo on March 9, 2009 at 12:55am

This removes the spacing around the image and removes the bullets in IE6/7. I think it'll fix it too on Mollom.

One observation: I think D7's Garland theme was changed awhile back that caused the white circle bullets in the login form to change to black solid bullets in non-IE browsers. Anybody can confirm that? If true, that needs a separate bug report.

EDIT:
Found it. #309784: Unordered lists override numbered lists

-repost-
Damnit! Why did the above post come out blank on submit? ^-- This is what I wrote.

#12

Posted by momendo on March 10, 2009 at 11:05am

#2, yes, it affects D6 and should probably be patched there as well.

#13

Posted by Jeff Burnz on March 24, 2009 at 11:38pm

Part of the problem is that neither of the item-list UL's have a class set on them making it difficult to theme the OpenID UL separately. Compounding the problem is the text-align center on #user-login-form.

While the above patch at least fixes the core issue by moving the icon to the left, it does not look that good since the alignment of the text is still wrong.

What I am going to propose is a seperate issue but I'd though I bring it up here anyway as its part of my overall idea:

1) remove text-align center on #user-login-form (why are we doing this anyway?)
2) set a class on the Openid UL
3) theme it so it looks great - just a matter of margins and padding.

This will ultimately give designers more control over theming the user login block, and at least the defualt stying will look right.

Thoughts?

#14

Posted by Jeff Burnz on March 26, 2009 at 5:23pm

I've come up with an alternative approach that both shows the icon correctly and the position of the text.

This patch moves the background image from the <li> to the <a> and sets a few sane defaults for ul for both #user-login-form and #user-login.

Garland will require a tweak.

AttachmentSizeStatusTest resultOperations
openidcss.patch1.41 KBIdleFailed: Failed to apply patch.View details

#15

Posted by System Message on March 26, 2009 at 9:56pm
Status:needs review» needs work

The last submitted patch failed testing.

#16

Posted by Jeff Burnz on March 26, 2009 at 10:52pm

Wrong path, trying again.

AttachmentSizeStatusTest resultOperations
openidcss.patch1.44 KBIdleFailed: Invalid PHP syntax in openid.css .View details

#17

Posted by Jeff Burnz on March 26, 2009 at 10:56pm
Status:needs work» needs review

#18

Posted by System Message on March 26, 2009 at 11:05pm
Status:needs review» needs work

The last submitted patch failed testing.

#19

Posted by Jeff Burnz on March 26, 2009 at 11:38pm
Status:needs work» needs review

OK, try one more time and see if this flys, otherwise I need someone to take a look and see what I am doing wrong here.

I assume there was a tab and not 2 spaces.

Arrr, fm, ignore the name of this patch... :/

AttachmentSizeStatusTest resultOperations
user-picture-v4-410044.patch1.46 KBIdlePassed: 10671 passes, 0 fails, 0 exceptionsView details

#20

Posted by netsensei on March 27, 2009 at 3:35pm

Tested the patch in #19 with Stark theme in Safari 3.2, IE6, IE7 and Firefox 3.07. The original issue is fixed in all cases: the image doesn't shift under the text.

Needs testing in IE8? Otherwise I would RTBC.

#21

Posted by Jeff Burnz on March 27, 2009 at 3:51pm

Tested also on Stark in IE8 (latest), Chrome and Opera 9.62 - fixed in all instances.

#22

Posted by Jody Lynn on March 31, 2009 at 2:21am
Status:needs review» reviewed & tested by the community

#23

Posted by Dries on March 31, 2009 at 10:48am
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks!

#24

Posted by Jody Lynn on April 1, 2009 at 2:18pm
Version:7.x-dev» 6.x-dev
Status:fixed» patch (to be ported)

This fix should be backported.

#25

Posted by Jeff Burnz on April 1, 2009 at 2:27pm

Yes, the CSS is the same from what I recall, until such time that it is backported you can do this - http://adaptivethemes.com/fix-your-openid-login-icon

#26

Posted by Jeff Burnz on May 29, 2009 at 10:54am
Status:patch (to be ported)» fixed

This was committed to drupal 6.11.

#27

Posted by System Message on June 12, 2009 at 11:00am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#28

Posted by alexanderpas on November 17, 2009 at 5:54am
Issue tags:-OpenID

Do NOT use tags for duplicating the "Assigned" or "Component" fields.