Problems with conversion of views from 1.x [#316556]

I'm working on updating the audio module's views support and using the import tool to migrate the default views from 1.x. It's been a big time saver but the thing I'm noticing some problems. None are critical but I wanted to report them so there's an issue where people can discuss them.

Here's a simple example

  $view = new stdClass();
  $view->name = 'audio_random';
  $view->description = 'Random audio nodes';
  $view->access = array(
  0 => '1',
  1 => '2',
);
  $view->view_args_php = '';
  $view->block = TRUE;
  $view->block_title = 'Random audio';
  $view->block_header = '';
  $view->block_header_format = '1';
  $view->block_footer = '';
  $view->block_footer_format = '1';
  $view->block_empty = '';
  $view->block_empty_format = '1';
  $view->block_type = 'list';
  $view->nodes_per_block = '5';
  $view->block_more = FALSE;
  $view->block_use_page_header = FALSE;
  $view->block_use_page_footer = FALSE;
  $view->block_use_page_empty = FALSE;
  $view->sort = array(
    array(
      'tablename' => 'node',
      'field' => 'random',
      'sortorder' => 'ASC',
      'options' => '',
    ),
  );
  $view->argument = array(
  );
  $view->field = array(
    array(
      'tablename' => 'node',
      'field' => 'title',
      'label' => '',
      'handler' => 'views_handler_field_nodelink',
      'options' => 'link',
    ),
  );
  $view->filter = array(
    array(
      'tablename' => 'node',
      'field' => 'type',
      'operator' => 'OR',
      'options' => '',
      'value' => array(
  0 => 'audio',
),
    ),
    array(
      'tablename' => 'node',
      'field' => 'status',
      'operator' => '=',
      'options' => '',
      'value' => '1',
    ),
  );
  $view->exposed_filter = array(
  );
  $view->requires = array('node');
  $views[$view->name] = $view;

Has the following problems:

Filters are loosing their values. The correct filters are selected but the values are lost.
Random sorting is lost.
block_type isn't used to set the Block's style.
nodes_per_block settings is lost.

Here's another problematic example:

  $view = new stdClass();
  $view->name = 'audio_feeds';
  $view->description = 'Audio XSPF Player';
  $view->access = array(
    0 => '1',
    1 => '2',
  );
  $view->view_args_php = '';
  $view->page = TRUE;
  $view->page_title = 'Listening Station';
  $view->page_header = '';
  $view->page_header_format = '1';
  $view->page_footer = '';
  $view->page_footer_format = '1';
  $view->page_empty = '';
  $view->page_empty_format = '1';
  $view->page_type = 'audio_xspf_playlist';
  $view->url = 'audio/listen';
  $view->use_pager = FALSE;
  $view->nodes_per_page = '15';
  $view->sort = array(
    array(
      'tablename' => 'node',
      'field' => 'created',
      'sortorder' => 'DESC',
      'options' => 'normal',
    ),
  );
  $view->argument = array(
    array(
      'type' => 'rss_feed',
      'argdefault' => '2',
      'title' => '',
      'options' => '',
      'wildcard' => '',
      'wildcard_substitution' => '',
    ),
  );
  $view->field = array(
    array(
      'tablename' => 'node',
      'field' => 'title',
      'label' => '',
      'handler' => 'views_handler_field_nodelink_with_mark',
      'options' => 'link',
    ),
  );
  $view->filter = array(
    array(
      'tablename' => 'node',
      'field' => 'type',
      'operator' => 'OR',
      'options' => '',
      'value' => array(
          0 => 'audio',
        ),
    ),
    array(
      'tablename' => 'node',
      'field' => 'status',
      'operator' => '=',
      'options' => '',
      'value' => '1',
    ),
  );
  $view->exposed_filter = array();
  $view->requires = array(node);
  $views[$view->name] = $view;

Gives some warnings on import:

    * notice: Undefined property: stdClass::$menu in /Users/amorton/Sites/d6/sites/all/modules/views/includes/convert.inc on line 166.
    * notice: Undefined index: field in /Users/amorton/Sites/d6/sites/all/modules/cck/includes/views/content.views_convert.inc on line 35.

It's got similar problems:

Filters don't have values.
Feed argument handler isn't converted to a feed display.

Some of these problems might be due to the custom page_type.

Comment	File	Size	Author
#43	views_convert-316556-43.patch	12.98 KB	darren oh
#41	views_convert-316556-41.patch	3.81 KB	darren oh
#37	views-content-316556-37.patch	48.94 KB	JirkaRybka
#35	views_convert-316556-35.patch	49.46 KB	darren oh
#34	views_convert-316556-34.patch	49.42 KB	darren oh
#33	views_convert-316556-33.patch	31.46 KB	darren oh
#32	views_convert-316556-32.patch	30.56 KB	darren oh
#31	views_convert-316556-31.patch	31.53 KB	darren oh
#30	views_convert-316556-30.patch	25.38 KB	darren oh
#29	views_convert-316556-29.patch	24.16 KB	darren oh
#25	views_convert-316556-25.patch	17.68 KB	darren oh
#23	views_convert-316556-23.patch	17.19 KB	darren oh
#19	views_convert-316556-19.patch	16.72 KB	darren oh
#18	views_convert-316556-17.patch	14.66 KB	darren oh
#16	views_convert-316556-16.patch	1.72 KB	darren oh
#9	views_convert-316556-9.patch	30.46 KB	darren oh
#8	node.views_convert.inc-316556-8_HEAD.patch	1.29 KB	darren oh
#3	views-316556-3_HEAD.patch	10.88 KB	darren oh
#2	views-316556-2_HEAD.patch	1.63 KB	darren oh

Comments

Comment #1

merlinofchaos commented 7 October 2008 at 21:48

The converter has been a relatively low priority for me, so I'm not surprised that its best effort isn't a very good one. This is a place where patches would be very welcome.

Version:	6.x-2.x-dev	» 6.x-2.2
Status:	Active	» Reviewed & tested by the community

Version:	6.x-2.3	» 6.x-2.x-dev
Status:	Needs work	» Needs review