There are several minor bugs in messaging -- mostly in Drupal.messages.set():
1. Messages are sometimes incorrectly duplicated when the third flag of messages.set() is false.
2. Messages are not removed from the DOM, so every new message displays all old messages as well.
3. If message is blank, then messages.set() sets a message that says 'undefined'; should be no message set.
4. String comparisons for old messages weren't working properly.

Patch forthcoming.

CommentFileSizeAuthor
#1 patch_316749_00.txt5.81 KBmbutcher

Comments

mbutcher’s picture

mbutcher commented
Status: Active » Needs review
StatusFileSize
new patch_316749_00.txt5.81 KB

Attached is a patch that addresses the four issues above, plus:
1. It removes dependence on Drupal.strEqual() in favor of the local Drupal.messages.strEqual()
2. It fixes some indenting.
3. Minor doc fixes.

litwol’s picture

litwol commented
Status: Needs review » Fixed

Committed: http://drupal.org/cvs?commit=147975

Thank you for your contribution.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.