In the current distribution, the IP Ban routine checks to see if banning is disabled. It should check if banning is ENABLED instead, otherwise the option is misleading and can lead to major problems for people who assume the system is working. That is, line 18 needs to be:

if(variable_get('troll_enable_ip_ban', TRUE)) {

Thanks for the software!

Comments

aschmitz’s picture

aschmitz commented

This was my bug submission, I just didn't have a Drupal account and didn't have time to create one before submitting this bug (qwerty1234 is a bugmenot account). Sorry. If someone with the power wants to modify the owner of the original submission, feel free.

harry slaughter’s picture

harry slaughter
Location Omaha NE USA
commented

i find it utterly sad that so many bugs get ignored :(

crunchywelch’s picture

crunchywelch commented
Status: Needs review » Closed (works as designed)

You are misunderstanding the code. The FALSE you see is a parameter, not a comparator value. It is the default value if none is set. If you have IP banning enabled it does block ips as advertised.