http://skitch.com/alexbarth/aa5d/invite-bug

The problem is

_invite_validate_emails();

Where $emails can be empty if being called a second time on line 907 of invite.module rev 1.25.2.2 .

Maybe _invite_validate_emails() shouldn't filter out failed emails from the $emails array but leave it up to the caller to do this?

CommentFileSizeAuthor
#1 invite-validation.patch2.56 KBsmk-ka

Comments

smk-ka’s picture

smk-ka commented
Status: Active » Needs review
StatusFileSize
new invite-validation.patch2.56 KB

No, the second validation handler simply must not run when there are no more e-mails left to validate. This can be easily fixed by duplicating the if (count($emails) > 0) clause.

alex_b’s picture

alex_b commented

Thanks for the quick reaction... this patch works for me.

What's not expected is that when I add a mail address that exists and one that does not exist, I don't get any error messages but I'm just being kicked over to invites/pending as if all emails where taken.

alex_b’s picture

alex_b commented
Status: Needs review » Reviewed & tested by the community

This patch works great and is ready to be committed. I created a new issue for #2 here http://drupal.org/node/320771

liquidcms’s picture

liquidcms commented

This patch is pretty old but issue still exists today. And i see latest dev release is back in Nov08, a month after this patch submitted - plus it is now Apr09. Is this module still being maintained as it seems like a lot of issues in the cue and no commits in > 6 months.. :(

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

Sorry, but also thanks, I mistakenly committed the very same fix based on a patch in #310775: Duplicate email causes nasty warning (note, identical result).

So, although the other issue was a duplicate, marking this issue fixed as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.