Compact display drops node-unpublished class

AlexisWilke - October 5, 2008 - 23:33
Project:Announcements
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed
Description

Hi Nancy,

The default node setup shows a class="node node-unpublished", but your compact mode does not show anything. It think that we should show something. I have a patch for that, also you may not want to call it node, it is okay, to my point of view, since the content is very close to the content of a node.

And this way, an announcement that's out of date still shows with a red background.

Thank you.
Alexis Wilke

AttachmentSize
announcements-compact-6.x-1.x-dev.patch658 bytes

#1

NancyDru - October 6, 2008 - 01:22

Actually, this is more of a theming issue. I am mulling this one over. I'm thinking about eliminating that setting and just saying that teaser format is abstract-only (BTW, see the suggestion in #260851: Various Issues/Suggestions/Requests). Then theming should take over and fix this problem.

#2

AlexisWilke - October 6, 2008 - 05:27

I will have to see how your solution works. In some way we need the unpublished class. I guess what you mean is to show the normal node with only the teaser which is similar to showing the abstract. Actually, I think that would be a lot better (i.e. completely eliminate the abstract since all nodes have a teaser capability now.)

One down side is that some people may like to write a different abstract than the teaser (or the beginning) of their full message...

Thank you.
Alexis

#3

NancyDru - October 6, 2008 - 13:12

I would still have the teaser entered separately, but use the node's teaser field to save it. That eliminates the need for storing it in a separate table. My thoughts are to save it off in hook_load and put it back in hook_update/hook_insert. Now, if I could just figure out how to save the publish and expiration dates, I could eliminate the table entirely.

#4

NancyDru - October 6, 2008 - 14:03
Status:needs review» fixed

Committed on both branches.

#5

Anonymous (not verified) - October 20, 2008 - 14:13
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.