Form not 100% compatible with D6

AlexisWilke - October 6, 2008 - 05:40
Project:Announcements
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

As I was playing with the filterbynodetype module and verifying the filters to all my node types, I bumped in this problem...

To properly setup the body in a form, you need to call the node_body_field() function (you can have a look in the simplenews module.) This gives you the proper filters, among other things.

I did not change the Abstract in a similar way, but I'm thinking that maybe the abstract should also receive the same treatment. But I do not think we could have two sets of input filters... And speaking of that, this means the filters are probably not applied to the abstract content. Something to think about.

On top of that, the title can be hidden and renamed by the user. The renaming of the body will happen in the node_body_field() call. I know that may sounds a bit strange, but I'd be fine with it. Only the admins can really tweak these things so they can make it work properly anyway.

I'm attaching my patch.

Thank you.
Alexis Wilke

AttachmentSize
announcements-form-6.x-dev.patch1.75 KB

#1

NancyDru - October 6, 2008 - 13:27
Status:needs review» fixed

Could have sworn I had done that...

#2

Anonymous (not verified) - October 20, 2008 - 13:42
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.