Hi,

CivicActions is reviewing and upgrading multiple modules for use on client sites. Part of this is a code review. Only 4 problems were found and are fixed in the attached patch.

There's one code style change, and one change in relation to commenting standards. For the menu_get_object() change, see http://drupal.org/node/114774#menu_get_object for more info. The last change is for internationalization - all strings passed to the t() function should not have leading or trailing spaces as this can cause problems for the translators, resulting in translated strings never appearing.

Cheers,
Stella

CommentFileSizeAuthor
service_links_codereview.patch2.36 KBstella

Comments

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

I've reviewed this, and it applies cleanly. All the changes look good so RTBC.

alexandreracine’s picture

alexandreracine commented

Does this work? Should the patch be commited? Is it already fixed?

TheCrow’s picture

TheCrow commented
Status: Reviewed & tested by the community » Fixed

@stella ty for the patch
@alexandreracine ty for up this discussion

these changes are now in the 6.x-1.x-dev version :))

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.