Patch for problems found in code review
stella - October 6, 2008 - 11:13
| Project: | Service links |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
Hi,
CivicActions is reviewing and upgrading multiple modules for use on client sites. Part of this is a code review. Only 4 problems were found and are fixed in the attached patch.
There's one code style change, and one change in relation to commenting standards. For the menu_get_object() change, see http://drupal.org/node/114774#menu_get_object for more info. The last change is for internationalization - all strings passed to the t() function should not have leading or trailing spaces as this can cause problems for the translators, resulting in translated strings never appearing.
Cheers,
Stella
| Attachment | Size |
|---|---|
| service_links_codereview.patch | 2.36 KB |
#1
I've reviewed this, and it applies cleanly. All the changes look good so RTBC.
#2
Does this work? Should the patch be commited? Is it already fixed?
#3
@stella ty for the patch
@alexandreracine ty for up this discussion
these changes are now in the 6.x-1.x-dev version :))
#4
Automatically closed -- issue fixed for 2 weeks with no activity.