Hi,

CivicActions is reviewing and upgrading multiple modules for use on client sites. Attached is a patch for problems found in relation to differences between Drupal 5 and Drupal 6.

The changes cover the following areas:

For the 2nd one, there is one instance of the comment_form_location variable which I didn't fix. It still needs to be corrected, but I was unsure how you wanted to handle it, since the node type isn't available in the function in which it is used. It appears on line 160 of nodecomment.module.

Cheers,
Stella

CommentFileSizeAuthor
nodecomment_upgradeD6_0.patch4.99 KBstella

Comments

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

This applies cleanly and everything looks good. Marking RTBC.

sirkitree’s picture

sirkitree commented

Thanks stella and catch.

stella, regarding the instance of comment_form_location on the settings form, this setting applies to all content types and I don't think we really want to have a separate setting for each content type a site has, do we?

stella’s picture

stella commented

sirkitree: the thing is that comment_form_location was a variable provided by core in Drupal 5. It no longer exists in Drupal 6, so you can't use it. Drupal 6 now has separate comment settings for each content type. I'm afraid it's not a matter of which we would prefer to have.

sirkitree’s picture

sirkitree commented
Status: Reviewed & tested by the community » Fixed
stella’s picture

stella commented
Status: Fixed » Active

There is still one usage of the deprecated variable 'comment_form_location' on line 160 of nodecomment.module

alexandreracine’s picture

alexandreracine commented

Does this work? Should the patch be commited? Is it already fixed?

zroger’s picture

zroger commented
Status: Active » Fixed

fixed in http://drupal.org/node/365475#comment-1399126

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.