Drupal 5.10
PHP 5.2.6

In testing registrations with the module enabled, I am not getting any error messages during user registration, or log messages showing that I am using a disposable email address. I am validating that the email addresses are not valid (i.e., DEA) by going to undisposable.net and using the Try Now! at the top of the page.

A sample e-mail address that is shown as not valid by undisposable.net is: bob@temporaryinbox.com
Using that same e-mail address when creating an account shows no warning, provides no log message, and the account is created as normal for the site.

I'm hoping to verify that someone is seeing the module work as expected. And also if there is something specific I should be doing to troubleshoot this further.

Thanks.

Comments

phdhiren’s picture

phdhiren commented

Not working for me too for both Drupal 5 and Drupal 6.

I think this due to http://www.undisposable.net/services/php/isDisposableEmail/?email=phd@te... gives the blank response.

scoutbaker’s picture

scoutbaker commented

I get a response using the link you provided.

mustafau’s picture

mustafau commented

Sorry, I do not have time to look into this. If you submit a patch I will review it.

phdhiren’s picture

phdhiren commented
Status: Active » Closed (works as designed)

I suppose, sometimes the response from undisposable.net is blank and sometimes it comes as it is expected.

As the module is depends on third party web service it always not gives expected result. :(

scoutbaker’s picture

scoutbaker commented

This does not seem likely for my reported issue. My particular testing was done over multiple days, at different times. I also checked the status of the e-mail address before and after registering it on my test Drupal site.

Your comment does bring up an interesting thought regarding error handling. How does this module respond if it gets no response from the service? As an example, the Mollom module allows you to specify what you want it to do if it does not get a response.

phdhiren’s picture

phdhiren commented

@ScoutBaker : Agreed, There should be alternative in case of error occurs.

mustafau’s picture

mustafau commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Category: bug » feature
Status: Closed (works as designed) » Postponed (maintainer needs more info)

Seems like a reasonable feature request.

scoutbaker’s picture

scoutbaker commented
Category: feature » bug

The is still a bug report. Addresses identified as disposable at undisposable.net are being allowed to register in Drupal.

The extra conversation in #4/#5 would indeed make a feature request. I'm far more concerned with proper operation which does not currently seem to be working.

phdhiren’s picture

phdhiren commented

@ScoutBaker: Code at our end is in our control, while the response given by the third party website is not always in our control (Here it is http://www.undisposable.net/ ) Every time I request http://www.undisposable.net/services/php/isDisposableEmail/?email=phd@te... ,

It should return either of the following

a:2:{s:4:"stat";s:2:"ok";s:5:"email";a:1:{s:12:"isdisposable";b:1;}}
OR
a:2:{s:4:"stat";s:2:"ok";s:5:"email";a:1:{s:12:"isdisposable";b:0;}}

But in some case it returns blank page. (may be problem with the website)
That is the case when the module is not allowing to validate email such as bob@temporaryinbox.com

I think this discussion should be either continue at http://www.undisposable.net/ OR we need have some error mechanism at our module's code and discuss what to be done when it returns blank.

scoutbaker’s picture

scoutbaker commented

Just another update on this.

@phdhiren: I never see a blank page returned from undisposable.net. I have continued testing by checking the response immediately before and after registering an email address that I know is disposable.

@mustafau: If there is something I can do to try and troubleshoot this further, please let me know.

Thanks

mustafau’s picture

mustafau commented
Status: Postponed (maintainer needs more info) » Fixed

There was a typo in the function "_undisposable". I committed a fix to all branches.
Thank you for this report.

scoutbaker’s picture

scoutbaker commented

Just reporting that the issue is indeed fixed in the 5.x-1.x-dev release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.