Gabor,

using D6.x (which prints all PHP E_ALL notices), some unwanted warnings are displayed:

* Fieldset without '#attributes' predefined. Its fixed by replacing the line 1515 on includes/form.inc

  return '<fieldset'. (!empty($element['#attributes']) ? drupal_attributes($element['#attributes']) : '') .'>'. ($element['#title'] ? '<legend>'. $element['#title'] .'</legend>' : '') . (isset($element['#description']) && $element['#description'] ? '<div class="description">'. $element['#description'] .'</div>' : '') . (!empty($element['#children']) ? $element['#children'] : '') . (isset($element['#value']) ? $element['#value'] : '') ."</fieldset>\n";

* Taxonomy terms, when created/edited, call taxonomy_term_path() and was supposed to give an OBJECT $term, but sometimes its just the term ID.
Its fixed by replacing the line 100 on modules/taxonomy.module (well... it fixes the taxonomy_term_path() function instead fixing the calling)

  if (is_object($term)) {
    $vocabulary = taxonomy_vocabulary_load($term->vid);
    if ($vocabulary->module != 'taxonomy' && $path = module_invoke($vocabulary->module, 'term_path', $term)) {
      return $path;
    }
    return 'taxonomy/term/'. $term->tid;
  }
  return 'taxonomy/term/'. $term;

Sorry for not providing the patch file.

regards,

massa

CommentFileSizeAuthor
#13 remove-xmlrpc-notices-318218-13-D6.patch1.05 KBJorrit
#11 remove-xmlrpc-notices-318218-11-D6.patch920 bytesJorrit
#7 318218-notices.patch920 bytesJorrit

Comments

brmassa’s picture

brmassa commented
Status: Active » Needs review
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Active

There is no patch.

brmassa’s picture

brmassa commented
Title: PHP E_ALL warnings » PHP E_ALL warnings (with code fix)

Gabor,

another place where E_ALL warning pop up. This patch will fix. See includes/xmlrpc.inc, line 70

    if (!empty($xmlrpc_value->data->is_date)) {
      return 'date';
    }
    if (!empty($xmlrpc_value->data->is_base64)) {

regards,

massa

dpearcefl’s picture

dpearcefl commented

Is this still an issue using current Drupal 6?

Jorrit’s picture

Jorrit commented
Status: Active » Needs review

The xmlrpc issue is still present, and the fix proposed by brmassa is still valid.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Active

No file has been attached to this issue to review so there is nothing to review.

Jorrit’s picture

Jorrit commented
Status: Active » Needs review
StatusFileSize
new 318218-notices.patch920 bytes

Done

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

Needs work because the name of your file doesn't followed the prescribed method.

http://drupal.org/node/1319154
http://drupal.org/node/707484
http://drupal.org/patch/submit

git diff > [project_name]-[short-description]-[issue-number]-[comment-number].patch
Patching for multiple Drupal versions
Note: If the issue has been tagged for multiple versions, and the patch is different for the different versions, upload a patch for each version:

For D7, it should be named: [patchname]-D7.patch
For D8, it should be named: [patchname].patch
Note that with this naming convention, the -D7 patch will be ignored by the testbot. (See the note above about file names).

Jorrit’s picture

Jorrit commented

I will do this soon.

However, I notice that your first link says: "git diff > [description]-[issue-number]-[comment-number].patch" while the second one says: "git diff > [project_name]-[short-description]-[issue-number]-[comment-number].patch"

What format do you want?

Secondly, should I add -D6 or not? This bug already seems to be fixed in D7, although in a slightly different way. The patch therefore does not need backporting. I will update the patch file to use that method to keep the code the same, just in case there is some future update to both files.

Anonymous’s picture

Anonymous (not verified) commented

"git diff > [description]-[issue-number]-[comment-number].patch" for core patches
"git diff > [project_name]-[short-description]-[issue-number]-[comment-number].patch" for contrib module patches.

Unless the patch is for the most recent HEAD version which is current D8 then you should always add -D# where # represent the Drupal version the patch is for. It is main to help out the testbot. In this case it should end in -D6.

Jorrit’s picture

Jorrit commented
Status: Needs work » Needs review
StatusFileSize
new remove-xmlrpc-notices-318218-11-D6.patch920 bytes

Thanks for the clarification.

I have read the pages and http://drupal.org/node/1054616 says:

In general, automated testing of your patches on Drupal.org by the friendly testbot is a Good Thing. However, adding -DX at the end of the patch name will cause the testbot to skip testing of the patch. For example, my_module-spelling-9876543-13-D7.patch will be ignored.

So I wonder whether the test bot picks up this patch. We'll see.

And:

Following the nomenclature documented here, a Drupal core patch might look like: drupal-proper-title-987654321-23.patch. Please note that while some people opt to leave off the [project_name] from core patches, adding "drupal-" to the front helps distinguish core patches from others, and is therefore still recommended for consistency, clarity, and simplifying the instructions.

Status: Needs review » Needs work

The last submitted patch, 318218-notices.patch, failed testing.

Jorrit’s picture

Jorrit commented
Status: Needs work » Needs review
StatusFileSize
new remove-xmlrpc-notices-318218-13-D6.patch1.05 KB

Rerolled.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.