Hi,

CivicActions is reviewing and upgrading modules for use on client sites. A few issues were found with the token module during the review, mainly to do with changes in the form API between Drupal 5 and 6. I'm not sure if the functions modified are actually used in D6 or not, but attached is a patch which will update the API to D6.

Cheers,
Stella

CommentFileSizeAuthor
token_codereview.patch1.63 KBstella

Comments

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Changes are good, and this applies cleanly. RTBC.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Patch for problems found in code review » code review for token 6.x
Status: Reviewed & tested by the community » Fixed

Committed.

Thanks, stella and catch!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.