Yves, Karen or Jonathan,

using D6.x (which prints all PHP E_ALL notices), some unwanted warnings are displayed:

* When importing a node type (content_copy module), there is a warning about a non existing array index. Its fixed by changing /cck/modules/content_copy/content_copy.module on line 433:

  if (isset($GLOBALS['content_copy']['status']) && $GLOBALS['content_copy']['status'] == 'export' && in_array($form_id, $alter_forms)) {

* When importing an existing node again, there is a warning about a non existing variable. Its fixed by changing /cck/modules/content_copy/content_copy.module on line 410 (in fact, its a real bug):

        '%field_label' => $field['label'], '%field_name' => $field_name, '%type' => $type_name)));

* When importing a node that has groups (fieldsets), there is a warning about a non existing array index. I thought that was just another small warning but i found out another bug: the $form_values['type_name'] was supposed to have the node type, but it has not. The node type is never sent to fieldgroup_update_fields() function.

Sorry for not providing the patch file.

regards,

massa

Comments

karens’s picture

karens commented

I can see the first two problems, but I can't find any way that the last one is a problem. $form_value['type_name'] should only be empty if you chose the option to 'create' a new type, and if you do that, $type_name gets populated with the type name of the imported type.

Can you come up with steps to reproduce a situation where no type name gets to fieldgroup_update_fields()?

brmassa’s picture

brmassa commented

Karen,

hi! thanks for this fast response.

This last problem is twofold:
1* It is a PHP E_ALL "bug", coz the code is trying to pass a a non-existing array value to a function. It can be solved by:

  $node_type = empty($form_value['type_name']) ? '' : $form_value['type_name'];
  $default = _fieldgroup_field_get_group($node_type, $form_values['field_name']);

2* The value is not getting passed at all. Even when im importing a node again (over the old one). I can see this because the Devel's dpm($form_value['type_name']) is always empty and because the "content_group_fields" DB table has several entries with an empty "type_name" column. Steps to reproduce it: import a node once. Then, import it again, over the old one and print the $form_value['type_name'] variable. It will be empty.

regards,

massa

karens’s picture

karens commented

I still don't get it. What option are you selecting when you import the field, create a new type or selecting an existing type? If the second, you will have a type name in the form values. If the first, there should be a type name in your import code. If there is no type name in your import, how did you create it without one? I'm not able to do that unless I deliberately clobber the export code before I try to import it.

Once you create a bad value and export and re-import it, I am sure it will be goofed up, but I can't see any way to every get to that point.

karens’s picture

karens commented

And why don't you paste a copy of the code you are trying to import.

brmassa’s picture

brmassa commented

Karen,

i tested it again with the same errors. I basically exported a node type and tried to import it back (selecting the type name on the select box in order to "overwrite" it). If i dpm($form_value['type_name']) shows that the type name was empty.

But since you ask, here is a simple code. Try to import it as a new type than import it over.

$content[type]  = array (
  'name' => 'thing strange',
  'type' => 'thing',
  'description' => '',
  'title_label' => 'Title',
  'body_label' => 'Body',
  'min_word_count' => '0',
  'help' => '',
  'node_options' =>
  array (
    'status' => true,
    'promote' => true,
    'sticky' => false,
    'revision' => false,
  ),
  'language_content_type' => '0',
  'old_type' => 'thing',
  'orig_type' => '',
  'module' => 'node',
  'custom' => '1',
  'modified' => '1',
  'locked' => '0',
  'comment' => '2',
  'comment_default_mode' => '4',
  'comment_default_order' => '1',
  'comment_default_per_page' => '50',
  'comment_controls' => '3',
  'comment_anonymous' => 0,
  'comment_subject_field' => '1',
  'comment_preview' => '1',
  'comment_form_location' => '0',
);
$content[groups]  = array (
  0 =>
  array (
    'label' => 'group thing',
    'group_type' => 'standard',
    'settings' =>
    array (
      'form' =>
      array (
        'style' => 'fieldset',
        'description' => '',
      ),
      'display' =>
      array (
        'description' => '',
        'teaser' =>
        array (
          'format' => 'fieldset',
        ),
        'full' =>
        array (
          'format' => 'fieldset',
        ),
        0 =>
        array (
          'format' => 'fieldset',
        ),
        'token' =>
        array (
          'format' => 'fieldset',
        ),
        'label' => 'above',
      ),
    ),
    'weight' => '4',
    'group_name' => 'group_trething',
  ),
);
$content[fields]  = array (
  0 =>
  array (
    'label' => 'genericfield',
    'field_name' => 'field_genericfield',
    'type' => 'number_integer',
    'widget_type' => 'number',
    'change' => 'Change basic information',
    'weight' => '1',
    'description' => '',
    'default_value' =>
    array (
      0 =>
      array (
        'value' => '',
        '_error_element' => 'default_value_widget][field_genericfield][0][value',
      ),
    ),
    'default_value_php' => '',
    'default_value_widget' => NULL,
    'group' => 'group_trething',
    'required' => 0,
    'multiple' => '0',
    'min' => '',
    'max' => '',
    'prefix' => '',
    'suffix' => '',
    'allowed_values' => '',
    'allowed_values_php' => '',
    'op' => 'Save field settings',
    'module' => 'number',
    'widget_module' => 'number',
    'columns' =>
    array (
      'value' =>
      array (
        'type' => 'int',
        'not null' => false,
        'sortable' => true,
      ),
    ),
    'display_settings' =>
    array (
      'label' =>
      array (
        'format' => 'above',
      ),
      'teaser' =>
      array (
        'format' => 'default',
      ),
      'full' =>
      array (
        'format' => 'default',
      ),
      0 =>
      array (
        'format' => 'above',
      ),
      'token' =>
      array (
        'format' => 'default',
      ),
    ),
  ),
);

REMEMBER TO SEE THE $form_value['type_name'] BEHAVIOR or to delete the "^ E_NOTICE" from common.inc :)

regards,

massa

karens’s picture

karens commented
Status: Needs review » Fixed

OK, I found it. The clue was that it should not have let you try to add those fields to a content type where they already existed. The type name was missing because it was supposed to be going down a path to error out, but a bracket was in the wrong place and it was trying to add them in. Should be fixed now.

Thanks!

brmassa’s picture

brmassa commented

Karen

welcome.

massa

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.