Can't add a node context (You must select a node.) [#318288]

Related to support request #317367: nodes added to Panel Pages don't display

I'm trying to add a node context to a panel-page. There's only one node in this test site so far, and when I try to put the title or nid in the last text field of the popup dialog, I always get the error "You must select a node".

I think it might be due to line 124 in contexts/node.inc, where the following are being checked:

$form_state['values']['external']
$form_state['values']['nid']
$form_state['values']['node']

When I checked the contents of $form_state, it looks like it's actually in this form:

$form_state['external']
$form_state['nid']
$form_state['node']

I'm not well-versed enough in the Drupal 6 formapi to know what the right course of action is here, but the way it looks to me, this won't ever work without some kind of change. This would be my guess, but I'm not confident enough to roll a patch.

if (empty($form_state['values']['external']) && empty($form_state['values']['nid']) && empty($form_state['values']['node'])) {

Comments

Comment #1

catch

he/him

English

commented 10 October 2008 at 00:37

I can reproduce this, looks like incomplete fapi conversion - still some $form_values in there.

Comment #2

cpelham commented 12 October 2008 at 01:49

Status:

Active

» Needs review

Deleting all of the instances of ['values'] in node.inc from lines 121-164 enabled me to successfully add node contexts finally. I am not attaching a patch at this time as I don't really understand the reason for ['values'] being there or why removing it works or whether it might screw something else up. But if someone else who understands the code better can vouch for this, I can attach this simple patch.

Comment #3

kirkhoward commented 20 October 2008 at 22:23

Hey guys has this solution been proven or disproven? I am also experiencing the same problem... would love to see an experienced member to comment on this fix...?