Support for other kind of default subjects

arhak - October 8, 2008 - 07:36
Project:Re: Comment subjects
Version:6.x-1.3
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

I would like to have the ability to change the kind of message.
Use cases:
A) building a custom ticket tracking system with comment_cck and having subjects autonumeric like project issue tracker
B) having disabled comments wonk hide them from display view which is very helpful since there is a permalink direct to each comment, but having "Re: some very long title" repeated on each comment it's very confusing and misleading. might be (on certain configuration) better to have the author's name, or date, or time, or whatever

Ideally it would be token integration.
I'm posting a contributed dev version which solves above use cases A & B, but as that contribution solves another more important issue I'll post it there (#302145: Restriction to certain contenttypes?)

#1

ahoeben - October 8, 2008 - 09:11
Status:needs review» won't fix

Both A) and B) can be achieved with theming.

#2

arhak - October 8, 2008 - 12:17

really not following...
how it's supposed to be achieved with theming?
why couldn't "Re:" be achieved with theming as well?

#3

arhak - October 8, 2008 - 12:40
Status:won't fix» needs review

I still think that all three of your use cases (numeric, author, date) can and should be implemented through theming. I am open to discussion though

Well, as stated before, I don't see how theming would sort this out. And, if so, why couldn't "Re:" be sorted as well through theming?
I just started to develop my first theme, so I'm pretty much a newbie. Please, alight me.

OTH, there is always the argument than configuration could be preferably than theming.
quoting chasz's comment

themeing is great for the server admin but for the site admin is best to administer from the browser. and thats what CMS's are supposed to do

So please, review the proposed implementation and tell me latter about your decisions on each subject (this issue for the different default values and #302145 for content types discrimination)

Remember: the proposed patch solves this and #302145: Restriction to certain contenttypes?, maybe I should made two different patch, but I wasn't thinking even about literally patches, was just playing around and ended up rewriting the whole module, so it was posted here because it's more relevant to the content types discrimination. Here is the direct link

#4

arhak - October 8, 2008 - 12:59

at #318443: Integration with token (new branch request) you say you don't see the use cases, I won't fight for that argument, but it's some how tight with this one, so I'll try to make the point over here, since token it's too much work to ask for.

from comments on http://www.lullabot.com/articles/drupal_usability_comment_configuration
you can find a similar point of view

COMMENTS SHOULD NEVER HAVE SUBJECTS. Never. Not just no Subject field, but NO SUBJECT AT ALL. A comment is about the post, so the subject is the post. If you provide a field, people put content in the field which is confusing. If you don't provide a field, the subject ends up being the unintelligible first few words. Solution? Comments should be identified by Author and Date, and just not show a subject at all.

shame on me, now I know what you were talking about with other options being possible through theming, just too much time spent on page and node that I completely forgot about comments having their own template

But, without touching a tpl.php file, I wanted to change the comments configuration. Certainly would like to erase the subject once and for all, but found useful the permalink provided on the comment's subject, and didn't wanted to be the author's name nor other thing. The extra options of author and date were included just for the fun of it.
The really needed configuration was the autonumeric on certain content types, for issues or tickets. And there is no need of creating a template for that purpose since it would require to tell somebody that he/she has to create that template with exactly some specific name depending on the content type's machine name and be located on ... far enough from reality.
Don't see the use case yet?

#5

ahoeben - October 9, 2008 - 07:01
Status:needs review» closed

continued here: #318443: Integration with token (new branch request)

 
 

Drupal is a registered trademark of Dries Buytaert.