The batch API is used to display a graphical progress bar and a text message during long-running batch processes.
The progress bar works as expected, filling in as work is done until it is completely filled.
An accompanying text message also reports progress. But it reports it in terms of items remaining, not items completed. Thus the graphical information and the textual information present opposites. This is disconcerting. They should present the same information.
This one-line patch changes the textual message from "Remaining 6 of 10" to "Completed 4 of 10", as shown in the attached screenshot.
| Comment | File | Size | Author |
|---|---|---|---|
| completedjv.patch | 690 bytes | jvandyk | |
| progressmsg.png | 7.82 KB | jvandyk |
Comments
Comment #1
Anonymous (not verified) commentedI disagree. I like to see what remains instead.
Comment #2
catchStatus reports in every piece of software I've ever used tell you how many things have completed, rather than how many remain. This is reassuring, and saves some of the weirdness we currently get if you see a glimpse of 0/10 remaining - which is jarring. This has annoyed me for years, and it's a wonderful, wonderful patch.
Comment #3
webchickMakes sense to me. If we were truly showing the remaining tasks, we'd say 8.292392932923, 8.12871871829719, etc. as the portions of tasks were completed. ;)
Committed to HEAD. Thanks! We probably can't back-port this because it would cause a string change.
Comment #4
lyricnz commented+1 on the change. If nothing else, saying "completed X of Y" is better, because Y can change during the batch (extra jobs are added), and it feels nicer to have the target number go up, rather than the remaining number go up.
Edit: dang, crosspost.
Comment #5
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.