Version 6.x-2.4 contains incorrect version numbering in the .info file.

In the packaged download, there's a double version entry (one 2.1, the other 2.4) in the .info file.

A CVS-checkout with tag DRUPAL-6--2-4 contains one version entry, but the wrong one (2.1) in the .info file. The .install file has version 1.2. in the header. The .module file has 1.4 in the header.

Is this a CVS-packaging issue? Would be nice to have it solved.

Comments

danielb’s picture

danielb commented

Hmm the packaging script must append the values rather than change them if they're already there. I don't know what the deal with the header ones is - am I meant to change that manually or you should I trust the cvs to do it?

corneverbruggen’s picture

corneverbruggen commented

The .info file committed to CVS should not have a version number in it, and .info files checked out through CVS do not contain a version number (version = "6.x-x.x") either (see here.
Could it be the case that the last commit of the .info file you did contained a version number entry? I'm not too experienced with the Drupal packaging stuff though... but when I look at the file in cvs, I see it contains a version = line, which it should not.

Maybe you can remove all the lines below a " ; Information added by drupal.org packaging script" line and do a new commit, and create new release?

Hope this helps.

danielb’s picture

danielb commented

Thanks for the link. I'll change this on the next update to the module. I don't really see it as a problem since the information that comes 2nd will override the information earlier in the file.

corneverbruggen’s picture

corneverbruggen commented

It is indeed not a big problem, but when you use cvs-deployment (eventually in combination with the drush module, the status page will indicate that you currently have the 2.1 version, and that you should update to 2.4, while that 2.4 version actually is installed.

So drush will try to install the 2.4 version over and over again and the status page and admin pages will continue to have the red warning message stating that there are updates available. That's somewhat confusing for the user. So therefore: when are you planning your next update to the module? Would be really appreciated.

Thanks a lot.

danielb’s picture

danielb commented

It seems to me like this drush thing could just check for the latest occurence of the version string. Would save me the manual labour of having to delete stuff from the info file each time - stuff that I didn't even put there!

I'll fix it today :(

danielb’s picture

danielb commented

Fixed in 6.x-2.5 !

danielb’s picture

danielb commented
Status: Active » Fixed
corneverbruggen’s picture

corneverbruggen commented

Great. Thanks for fixing this and thanks for this nice module in the first place :-)

Farbridges

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.