Ok this might be minor as it just happens when there are no terms in db, but still it's an easy fix and I see no reason to not do it.

After installing taxonews and going to Blocks, in case there are no terms (typically when starting to build a site) a bunch of db related errors are triggered, making the main warning message about needed configuration "disapear" in the flora of messages. This little fix in taxonews.module approx line 420 cure it:

  /**
   * Query for terms in the vocabularies selected in settings
   *
   * @return array [tid, name]
   */
  static function getTerms()
    {
    static $arTerms = array();

    if (empty($arTerms))
      {
      $arVids = variable_get(self::VAR_VOCABULARY, array());
+      if (empty($arVids))
+        {
+          return false;
+        }
        
      $sq = 'SELECT td.tid, td.name, '

Possibly it can be done more effectively, but it works.

Comments

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

Thanks for your report. I fixed it a bit differently.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Active » Fixed

Fixed in today's version 1.10.8.9.

vikingew’s picture

vikingew commented

Ok guess that works as well ;-)

Another thing, instead of creating a DRUPAL-7 branch you should simply let HEAD keep the D7 development, not even core has a D7 branch (except for HEAD) as nothing been released yet.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

I don't like coding in HEAD for contrib, because one never knows what version or core it is good for, as this will evolve over time. Let me summarize a recent discussion about this on the dev list

  • dev Alice creates and maintains contrib module foo for D6, in HEAD
  • site admin Bob uses this module
  • at some random date, D7 becomes the current core branch while Alice is on vacation
  • at that instant, foo becomes broken because its HEAD version is no longer for drupal HEAD, although Alice changed nothing
  • the situation doesn't return to normal until Alice creates a D7 branch from her current foo HEAD

By contrast, had Alice kept foo branched per-core-branch, the launch of D7 core wouldn't have had any impact. For more details or discussion about this, I suggest you read http://drupal.org/node/17570, which describes the strategy I apply under the heading "Only sync changes to HEAD when you're going to start a new branch".

vikingew’s picture

vikingew commented

Well I couldn't disagree more as it's no good to build a strategy on an exception, but I will read the node an possibly dive into the discussion - so no point of discussing this further here ;-)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.