Using flexinode cvs in the current drupal head.

Only the root user can create flexinode content. Even with permissions set other users don't see the links on the create content page, although it does appear in the navigation menu (bug in drupal head?) the link there doesn't work.

Seems to be a problem with flexinode_access. I don't know enough to fix it though.

I do know that getting flexinode_access to return true allows normal users to post flexinode content, so the rest seems to work fine.

CommentFileSizeAuthor
#6 31880.patch1.79 KBsamc
#1 flexinode.module.47update.patch1.59 KBmoggy

Comments

moggy’s picture

moggy commented
Status: Active » Needs review
StatusFileSize
new flexinode.module.47update.patch1.59 KB

Ok, think I've sorted it

[code]- return user_access('create '. flexinode_node_name($node->type) .' content');
+ return user_access('create '. node_get_name($node) .' content');
[/code]

The patch attached fixes this problem plus a couple of other little changes that appeared to be needed to update to 4.7

moggy’s picture

moggy commented

Still missing table view. Just getting a blank page at the moment :(

Steve Dondley’s picture

Steve Dondley commented

See http://drupal.org/node/22218#theme_username for how to fix the blank page.

Bèr Kessels’s picture

Bèr Kessels commented
Priority: Normal » Critical
Status: Needs review » Needs work

This is an important patch. Its a first step towards a release for 4.7

Bèr Kessels’s picture

Bèr Kessels commented

also see the now closed thread http://drupal.org/node/29947

samc’s picture

samc commented
Title: Permissions don't work in drupal HEAD/4.7 » Remove flexinode_node_name()
StatusFileSize
new 31880.patch1.79 KB

Updated patch:

- removes flexinode_node_name() function definition
- replaces calls to flexinode_node_name() with node_get_name()
- replaces calls to format_name() with theme_username()

Works fine for me.

samc’s picture

samc commented
Status: Needs work » Needs review
Bèr Kessels’s picture

Bèr Kessels commented

Looks good, but needs testing.
Can someone please review?

Bèr Kessels’s picture

Bèr Kessels commented
Assigned: Unassigned » Bèr Kessels
Status: Needs review » Fixed

I reviewed, tested and committed.

Chances are that specific fields now show fatal errors, but for that we need to open separate issues.

Waldemar’s picture

Waldemar commented

I believe this patch introduces errors on translated pages. node_get_name gets you a translated name of the content type, however access permissions are set in the original language. I've checked that and if I give users the permission to post but translate the content type name, then that access permission is not applied.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)