Posted by mfb on October 9, 2008 at 6:19am
| Project: | SMS Framework |
| Version: | 6.x-2.x-dev |
| Component: | E-mail Gateway |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
SMS E-mail Gateway is missing support for Metro PCS and Boost Mobile.
| Attachment | Size |
|---|---|
| boost.metropcs.patch | 1.23 KB |
Comments
#1
Will be fixed with #331630: Add CRUD interface to E-mail Gateway module.
#2
I have a question about this. are you implying that you don't want to maintain an up-to-date list of carriers in this module? Because it seems like you'd want to both add missing carriers and add ability for admins to modify the list.
If you don't add the carriers here then everyone installing the module has to manually update the list. Or we need to maintain a separate contrib module implementing the hook like sms_carriers.module?
#3
mfb,
Yes you are right. We should maintain a proper list in addition to adding support for users to add their own. I'll commit this shortly. Thanks!
#4
by the way, one of our developers is based in Uruguay... so here's another you could add:
'mms.claro.com.uy' => t('Claro UY'),
of course, I'm guessing this is just barely scratching the surface of all the SMS e-mail gateways ;) so we'll definitely want the ability for admins to hide various carriers they don't need to support.
#5
What do you think about incorporating Laconica's carrier gateway database?
http://gitorious.org/laconica/mainline/blobs/master/db/sms_carrier.sql
Of course, I need to convert this to patch format.
#6
In this patch I added everything that Laconica supports plus a couple others, Claro Uruguay and Mobilink World (Pakistan).
#7
Re-rolled for the latest dev version of SMS Framework.
Also included a critical bug fix for sms_theme() breaking the forms.
#8
#9
Here is patch we are using on 1.x, to add some more US carriers and i've commented out the non US/CA/UK ones from the other patches. Would also like to see #33130 where all this can be stored and manipulated in db and not code of module.
#10
Hope this won't be committed with non-US/CA/UK carriers commented out? Also, what is the proper branch for patches adding new features? I was assuming that we'd first commit to 6.x-2.x then backport to 6.x-1.x
#11
Yep, lets focus on 2.x branch for new features - also why is the theme function removed in this patch?
#12
Here's an updated patch which merges in a couple additional carriers supported by StatusNet.
See #7: I had "also included a critical bug fix for sms_theme() breaking the forms" but maybe this is no longer needed.
#13
Can anyone explain to me why the carriers code is in the core sms module. Isn't it only useful for email gateways? So shouldn't it be moved over to be part of the sms_emailgateway module.
Also the more carriers that are added the more the need probably exists for a method to disable the ones people don't want visible or having a select that groups the carriers by country so users can easily find their carrier. That would require some meta data against the carriers - #972806: Support multiple carriers sharing the same SMS e-mail gateway
Other related issues to this one:
#587090: Please add these canadian sms_email_gateway_providers
#331630: Add CRUD interface to E-mail Gateway module
#14
I don't know the rationale around moving the carriers from sms_email_gateway.module to sms.module but here's the commit where it happened: http://drupal.org/cvs?commit=219458 "Initial code for a carrier management system with support for user overrides."
#15
This has been committed, thanks.
#16
#17
Automatically closed -- issue fixed for 2 weeks with no activity.